Fix link rel compression dictionary #26375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:http
…theweb/browser-compat-data into fix-link-rel-compression-dictionary
github-actions
bot
added
size:l
Elchi3
reviewed
Apr 4, 2025
There was a problem hiding this comment.
If a feature is created in web-features, we sync the tagging to BCD automatically. The build fails as the web-feature ID doesn't exist yet (but will once dependabot updates BCD's web-feature version and we sync the tags). For new features, I would always recommend to author things in web-features as that should be the source of truth. The docs for this live here: https://github.com/web-platform-dx/web-features/blob/main/docs/bcd-sync.md
|
Yeah it's already added in there. Just waiting for the next version which was released, but hasn't come through to this repo yet. I have removed the web-feature additions then if they will auto sync, but still have the other changes in this PR. |
github-actions
bot
added
size:m
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some fixes from #26257 :
compression-dictionary is alink relattribute, not alinkattribute. Also removed theexpects` one that caused this confustion (added in error in fetchPriority enabled by default in Firefox 132 #24518 I believe).Test results and supporting details
Related issues
#26257
#24518