-
Notifications
You must be signed in to change notification settings - Fork 669
feat(otelgin): add the WithGinMetricAttributes
option to allow setting dynamic, per-request metric attributes based on *gin.Context
#6932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmathieu
merged 13 commits into
open-telemetry:main
from
tranngoclam:otelgin-use-gin-context-metrics
Mar 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking change. We should at least deprecate the method for one release before breaking user's apps. |
In #5743, we added a new helper that took specifically a gin context. |
dc94339
to
b3e26be
Compare
Hi @dmathieu , I have updated to use a new func instead |
dmathieu
reviewed
Mar 17, 2025
dmathieu
reviewed
Mar 17, 2025
Co-authored-by: Damien Mathieu <[email protected]>
akats7
approved these changes
Mar 17, 2025
dmathieu
reviewed
Mar 18, 2025
Co-authored-by: Damien Mathieu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6932 +/- ##
=====================================
Coverage 75.7% 75.7%
=====================================
Files 207 207
Lines 19396 19403 +7
=====================================
+ Hits 14685 14692 +7
Misses 4275 4275
Partials 436 436
🚀 New features to boost your workflow:
|
dmathieu
reviewed
Mar 18, 2025
Co-authored-by: Damien Mathieu <[email protected]>
dmathieu
approved these changes
Mar 18, 2025
WithGinMetricAttributes
option to allow setting dynamic, per-request metric attributes based on *gin.Context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GinMetricAttributeFn
of packageotelgin
.