-
Notifications
You must be signed in to change notification settings - Fork 669
otelgin: add http.route metric attribute #7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
otelgin: add http.route metric attribute #7275
Conversation
Can you add some unit tests? |
Please add a CHANGELOG: https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md |
sure, will do |
5c09f8d
to
4a426ee
Compare
updated unit test and changelog |
4a426ee
to
758ef4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @open-telemetry/go-approvers @akats7
758ef4c
to
8374c20
Compare
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7275 +/- ##
=======================================
- Coverage 81.1% 81.1% -0.1%
=======================================
Files 204 204
Lines 18148 18151 +3
=======================================
Hits 14728 14728
- Misses 3001 3003 +2
- Partials 419 420 +1
🚀 New features to boost your workflow:
|
8374c20
to
8736109
Compare
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/gin-gonic/gin/otelgin/test/gin_test.go
Outdated
Show resolved
Hide resolved
8736109
to
793a005
Compare
Hi, @dmathieu, thanks for your comments, I've updated code and resolved them. |
Note: you should avoid force-pushing your branch. It makes reviews much easier. |
@dmathieu Got it. I thought I should alway only keep one commit for the PR. |
No. GitHub will squash once we merge the PR. |
That's cool. I'll keep in mind :-) |
Co-authored-by: Robert Pająk <[email protected]>
According to the Semantic conventions for HTTP metrics | OpenTelemetry,
http.route
is a stable label for http server metrics, I suggest to set it as a default label in the gin middleware.