Skip to content

test: test Node.js 24 in CI #5661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 14, 2025
Merged

test: test Node.js 24 in CI #5661

merged 4 commits into from
May 14, 2025

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented May 8, 2025

Which problem is this PR solving?

Testing on the latest version of Node.js

Fixes # N/A

Short description of the changes

Node.js v24 was recently released. This change adds it to the CI. (Adapted from 34a2dd5)

Type of change

  • Bug fix?

How Has This Been Tested?

  • Let's see what GitHub Actions says. The full test suite does not run locally for Node 23 or 24.

Checklist:

  • Followed the style guidelines of this project

@cjihrig cjihrig requested a review from a team as a code owner May 8, 2025 15:07
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (697e1d3) to head (4b5a0ed).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5661   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files         310      310           
  Lines        7992     7992           
  Branches     1614     1614           
=======================================
  Hits         7595     7595           
  Misses        397      397           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

cjihrig added 2 commits May 9, 2025 15:46
_headers was removed in 57551
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'll defer to @JamieDanielson on whether it would help to wait on merging this until her larger #5665 (in progress) is finished and merged.

@legendecas
Copy link
Member

#5665 was merged and there is no conflicts.

@pichlermarc pichlermarc added this pull request to the merge queue May 14, 2025
Merged via the queue into open-telemetry:main with commit 56610a0 May 14, 2025
17 checks passed
@opentelemetrybot
Copy link
Contributor

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the node24 branch May 14, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants