Update exception filtering to match against actual exception #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icemac
approved these changes
Apr 29, 2025
Thanks, I'll do. Which changelog category should I use for this? I initially thought the original behavior was a bug, but given the test coverage and README note around this, it seems it was an intentional design choice. |
|
@icemac I've added my change log under the "Other Changes" category for now. Please let me know if you prefer a different one. |
|
LGTM, enabling automerge. |
|
Released in https://pypi.org/project/pytest-rerunfailures/15.1/. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
This PR aims to change this function to check specified
only_rerunandrerun_exceptvalue(s) against the actual exception, instead of usingreport.longrepr.reprcrash.messageorreport.longreprtext.I wasn't sure why
report.longrepr.reprcrash.messageandreport.longreprtextare currently used. So please disregard/close the PR if my change looks invalid or would break something.