ActiveJob/serializers: Only index new serializers #55992
Merged
+30
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipkayhil
previously approved these changes
Oct 23, 2025
Member
|
CI is broken |
jsharpify
force-pushed
the
jsharpify-reduce-deprecation-warnings
branch
from
2702429 to
6e956aa
Compare
skipkayhil
reviewed
Oct 23, 2025
Comment on lines
55
to
56
| @serializers_index.clear | ||
| add_new_serializers(serializers) |
Member
There was a problem hiding this comment.
@serializers is a Set, but aren't we adding them twice now?
Contributor
Author
There was a problem hiding this comment.
Oops, yup. Emptying it out first and then assigning
jsharpify
force-pushed
the
jsharpify-reduce-deprecation-warnings
branch
from
6e956aa to
a292f53
Compare
Instead of reprocessing every serializer everytime a new serializer is added, just process the new one. This has the intended side-effect of only issuing the deprecation warning for non-compliant serializers once (when added) instead of on every subsequent call to add serializers. This also ensures that the filepath in the deperecation warning does not point to the innocent compliant serializers.
jsharpify
force-pushed
the
jsharpify-reduce-deprecation-warnings
branch
from
a292f53 to
9005422
Compare
rafaelfranca
added a commit
that referenced
this pull request
Oct 24, 2025
…-warnings ActiveJob/serializers: Only index new serializers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reprocessing every serializer everytime a new serializer is added, just process the new one. This has the intended side-effect of only issuing the deprecation warning for non-compliant serializers once (when added) instead of on every subsequent call to add serializers. This also ensures that the location deperecation warning does not point to the innocent compliant serializers. Currently when it reports the deprecation it will include the location of the most recent call to add_serializers which falsely implicates those serializers.