Skip to content

False negatives on the Style/MultipleComparison cop #13623

@ydakuka

Description

@ydakuka

Actual behavior

  def target_params
    selection_data = selection_data.except(:a) if selection_data[:type] == 'X' || selection_data[:type] == 'Y'
    selection_data.permit(:a, :b, :c)
  end
  def target_params
    selection_data = selection_data.except(:a) if selection_data['type'] == 'X' || selection_data['type'] == 'Y'
    selection_data.permit(:a, :b, :c)
  end

I've expected:

  def target_params
    selection_data = selection_data.except(:a) if %w[X Y].include?(selection_data[:type])
    selection_data.permit(:a, :b, :c)
  end
  def target_params
    selection_data = selection_data.except(:a) if %w[X Y].include?(selection_data['type'])
    selection_data.permit(:a, :b, :c)
  end

Rubocop

ydakuka@yauhenid:~/Work/project$ bin/rails_docker rubocop -V
1.69.2 (using Parser 3.3.4.2, rubocop-ast 1.36.2, analyzing as Ruby 2.7, running on ruby 2.7.8) [x86_64-linux]
  - rubocop-capybara 2.21.0
  - rubocop-factory_bot 2.26.1
  - rubocop-performance 1.23.0
  - rubocop-rails 2.27.0
  - rubocop-rake 0.6.0
  - rubocop-rspec 3.3.0
  - rubocop-rspec_rails 2.30.0
  - rubocop-thread_safety 0.6.0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions