Skip to content

Conversation

@yarikama
Copy link
Contributor

Description

This PR fixes the ValidationException that occurs when BedrockConverse calls tools without outputting any text in AgentWorkflow. The issue was that empty or None message content was being passed to AWS Bedrock API, which doesn't accept blank text fields.

Fix: Added fallback to "-" when message content is None or empty in messages_to_converse_messages function.

Test: Added integration test that reproduces the exact scenario from the issue to ensure the fix works correctly.

Fixes #18449

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change

Test Details:

  • Added test_bedrock_converse_agent_workflow_empty_text_error that reproduces the exact scenario from issue [Bug]: error in step 'run_agent_step' with BedrockConverse #18449
  • Test uses BedrockConverse with AgentWorkflow and FunctionAgent
  • Verifies that the ValidationException no longer occurs when LLM calls tools without text output

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran uv run make format; uv run make lint to appease the lint gods

…tionException (run-llama#18449)

- Add fallback to "-" when message content is None or empty
- Add integration test to verify the fix works with AgentWorkflow
- Prevents "The text field in the ContentBlock object is blank" error
- Bump version from 0.7.0 to 0.7.1
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 31, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 2, 2025
@yarikama yarikama requested a review from logan-markewich June 2, 2025 04:06
yarikama added 3 commits June 3, 2025 10:42
@yarikama yarikama requested a review from logan-markewich June 3, 2025 02:46
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 3, 2025
@logan-markewich logan-markewich merged commit 5a1249e into run-llama:main Jun 3, 2025
9 of 10 checks passed
@yarikama yarikama deleted the fix/bedrock-converse-empty-text-18449 branch June 3, 2025 14:44
@colca colca mentioned this pull request Jun 9, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: error in step 'run_agent_step' with BedrockConverse

2 participants