-
Notifications
You must be signed in to change notification settings - Fork 6.7k
fix(bedrock-converse): handle empty message content to prevent Valida… #18914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
logan-markewich
merged 7 commits into
run-llama:main
from
yarikama:fix/bedrock-converse-empty-text-18449
Jun 3, 2025
Merged
fix(bedrock-converse): handle empty message content to prevent Valida… #18914
logan-markewich
merged 7 commits into
run-llama:main
from
yarikama:fix/bedrock-converse-empty-text-18449
Jun 3, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tionException (run-llama#18449) - Add fallback to "-" when message content is None or empty - Add integration test to verify the fix works with AgentWorkflow - Prevents "The text field in the ContentBlock object is blank" error - Bump version from 0.7.0 to 0.7.1
yarikama
commented
May 31, 2025
...tegrations/llms/llama-index-llms-bedrock-converse/llama_index/llms/bedrock_converse/utils.py
Outdated
Show resolved
Hide resolved
yarikama
commented
May 31, 2025
...ndex-integrations/llms/llama-index-llms-bedrock-converse/tests/test_llms_bedrock_converse.py
Show resolved
Hide resolved
yarikama
commented
May 31, 2025
llama-index-integrations/llms/llama-index-llms-bedrock-converse/pyproject.toml
Show resolved
Hide resolved
yarikama
commented
May 31, 2025
...ndex-integrations/llms/llama-index-llms-bedrock-converse/tests/test_llms_bedrock_converse.py
Show resolved
Hide resolved
yarikama
commented
May 31, 2025
...tegrations/llms/llama-index-llms-bedrock-converse/llama_index/llms/bedrock_converse/utils.py
Outdated
Show resolved
Hide resolved
yarikama
commented
Jun 2, 2025
...tegrations/llms/llama-index-llms-bedrock-converse/llama_index/llms/bedrock_converse/utils.py
Show resolved
Hide resolved
yarikama
commented
Jun 2, 2025
...tegrations/llms/llama-index-llms-bedrock-converse/llama_index/llms/bedrock_converse/utils.py
Show resolved
Hide resolved
yarikama
commented
Jun 2, 2025
...ndex-integrations/llms/llama-index-llms-bedrock-converse/tests/test_llms_bedrock_converse.py
Show resolved
Hide resolved
...tegrations/llms/llama-index-llms-bedrock-converse/llama_index/llms/bedrock_converse/utils.py
Outdated
Show resolved
Hide resolved
…fix/bedrock-converse-empty-text-18449
…rikama:yarikama/llama_index into fix/bedrock-converse-empty-text-18449
logan-markewich
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the ValidationException that occurs when BedrockConverse calls tools without outputting any text in AgentWorkflow. The issue was that empty or None message content was being passed to AWS Bedrock API, which doesn't accept blank text fields.
Fix: Added fallback to "-" when message content is None or empty in
messages_to_converse_messagesfunction.Test: Added integration test that reproduces the exact scenario from the issue to ensure the fix works correctly.
Fixes #18449
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
Test Details:
test_bedrock_converse_agent_workflow_empty_text_errorthat reproduces the exact scenario from issue [Bug]: error in step 'run_agent_step' with BedrockConverse #18449Suggested Checklist:
uv run make format; uv run make lintto appease the lint gods