Update bundled c-ares to v1.34.5 #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
c-ares/c-ares@70f10a8 breaks test_idna_encoding_query_a |
|
its the error that changed when incorrectly passing bytes. this is just fine |
bdraco
added a commit
to bdraco/pycares
that referenced
this pull request
May 2, 2025
In saghul#221 I did a lot of pushes to figure out what had changed between versions. The previous jobs kept running and the CI got tied up.
This comment has been minimized.
This comment has been minimized.
bdraco
changed the title
bdraco
changed the title
saghul
pushed a commit
that referenced
this pull request
May 2, 2025
In #221 I did a lot of pushes to figure out what had changed between versions. The previous jobs kept running and the CI got tied up.
3 tasks
This was referenced May 2, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us up to date with c-ares. The regressions I was worried about earlier in the previous PR were fixed in 1.33.1 c-ares/c-ares#852 , and I was able to get all the way to the latest version (v1.34.5) with the only change to the tests being for
test_idna_encoding_query_agot a different error code when passingbytesinstead ofstr, which is expected.https://c-ares.org/changelog.html
Testing
I tested this on multiple production Home Assistant installs along with aio-libs/aiodns#145