Skip to content

Commit 0e8582f

Browse files
committed
Test responseType set to undefined
Fixes #1252
1 parent 9b04963 commit 0e8582f

File tree

3 files changed

+13
-0
lines changed

3 files changed

+13
-0
lines changed

source/as-promise/core.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,12 @@ export default class PromisableRequest extends Request {
5757
assert.any([is.boolean, is.undefined], options.resolveBodyOnly);
5858
assert.any([is.boolean, is.undefined], options.methodRewriting);
5959
assert.any([is.boolean, is.undefined], options.isStream);
60+
assert.any([is.string, is.undefined], options.responseType);
61+
62+
// `options.responseType`
63+
if (options.responseType === undefined) {
64+
options.responseType = 'text';
65+
}
6066

6167
// `options.retry`
6268
const {retry} = options;

source/core/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,7 @@ export default class Request extends Duplex implements RequestEvents<Request> {
624624
assert.any([is.boolean, is.undefined], options.http2);
625625
assert.any([is.boolean, is.undefined], options.allowGetBody);
626626
assert.any([is.boolean, is.undefined], options.rejectUnauthorized);
627+
assert.any([is.string, is.undefined], options.localAddress);
627628

628629
// `options.method`
629630
if (is.string(options.method)) {

test/response-parse.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,12 @@ test('Text response', withServer, async (t, server, got) => {
4444
t.is((await got({responseType: 'text'})).body, jsonResponse);
4545
});
4646

47+
test('Text response #2', withServer, async (t, server, got) => {
48+
server.get('/', defaultHandler);
49+
50+
t.is((await got({responseType: undefined})).body, jsonResponse);
51+
});
52+
4753
test('JSON response - promise.json()', withServer, async (t, server, got) => {
4854
server.get('/', defaultHandler);
4955

0 commit comments

Comments
 (0)