Got promise shouldn't retry when the body is a stream

Fixes #1382

Author: szmarczak

source/as-promise/index.ts

@@ -1,4 +1,5 @@
 import {EventEmitter} from 'events';
+import is from '@sindresorhus/is';
 import PCancelable = require('p-cancelable');
 import {
 	NormalizedOptions,
@@ -128,7 +129,7 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 				resolve(request.options.resolveBodyOnly ? response.body as T : response as unknown as T);
 			});
 
-			request.once('error', async (error: RequestError) => {
+			const onError = (error: RequestError) => {
 				if (promise.isCanceled) {
 					return;
 				}
@@ -142,9 +143,16 @@ export default function asPromise<T>(normalizedOptions: NormalizedOptions): Canc
 				}
 
 				reject(error);
-			});
+			};
+
+			request.once('error', onError);
+
+			request.once('retry', (newRetryCount: number, error: RequestError) => {
+				if (is.nodeStream(error.request?.options.body)) {
+					onError(error);
+					return;
+				}
 
-			request.once('retry', (newRetryCount: number) => {
 				makeRequest(newRetryCount);
 			});
 

source/core/index.ts

@@ -1394,10 +1394,6 @@ export default class Request extends Duplex implements RequestEvents<Request> {
 			body.once('error', (error: NodeJS.ErrnoException) => {
 				this._beforeError(new UploadError(error, this));
 			});
-
-			body.once('end', () => {
-				delete options.body;
-			});
 		} else {
 			this._unlockWrite();
 

test/retry.ts

@@ -509,3 +509,23 @@ test('throws when cannot retry a Got stream', withServer, async (t, server, got)
 	t.is(error.response.body, 'not ok');
 	t.is(globalRetryCount, 2);
 });
+
+test('promise does not retry when body is a stream', withServer, async (t, server, got) => {
+	server.post('/', (_request, response) => {
+		response.statusCode = 500;
+		response.end('not ok');
+	});
+
+	const body = new PassThroughStream();
+	body.end('hello');
+
+	const response = await got.post({
+		retry: {
+			methods: ['POST']
+		},
+		body,
+		throwHttpErrors: false
+	});
+
+	t.is(response.retryCount, 0);
+});