Skip to content

fix(es/minifier): Fix access to GLOBALS in char freq compute #10239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 20, 2025

Description:

The bug was not detected because chili is far better for reusing current thread.

@kdy1 kdy1 added this to the Planned milestone Mar 20, 2025
@kdy1 kdy1 self-assigned this Mar 20, 2025
@kdy1 kdy1 requested a review from a team as a code owner March 20, 2025 16:31
Copy link

changeset-bot bot commented Mar 20, 2025

⚠️ No Changeset found

Latest commit: 0bdf9dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 merged commit 6286663 into main Mar 20, 2025
16 checks passed
@kdy1 kdy1 deleted the kdy1/fix-base54 branch March 20, 2025 16:31
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10239 will improve performances by 1.33%

Comparing kdy1/fix-base54 (0bdf9dd) with main (c47b9da)

Summary

⚡ 2 improvements
✅ 150 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
serialization of serde 2.8 µs 2.8 µs +1.06%
es/lints/libs/terser 29.5 ms 29.1 ms +1.33%

@kdy1 kdy1 modified the milestones: Planned, v1.11.12 Mar 23, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Apr 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant