Skip to content

test(es): Unignore tests #10348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 10, 2025
Merged

test(es): Unignore tests #10348

merged 6 commits into from
Apr 10, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Apr 10, 2025

Description:

I wiped the Github Actions cache for the swc repository, so I'm re-enabling this.

@kdy1 kdy1 added this to the Planned milestone Apr 10, 2025
Copy link

changeset-bot bot commented Apr 10, 2025

⚠️ No Changeset found

Latest commit: e337dc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1
Copy link
Member Author

kdy1 commented Apr 10, 2025

cc @magic-akari It still fails

@magic-akari
Copy link
Member

I encountered the same error when I switched my Node version to 18 locally.

For our exec tests, we execute the code both before and after transformation and then compare their outputs.
Therefore, my guess is that the error is happening in the original (pre-transformation) code execution.

@kdy1
Copy link
Member Author

kdy1 commented Apr 10, 2025

Oh then I'll update nodejs to 20

@kdy1
Copy link
Member Author

kdy1 commented Apr 10, 2025

Thank you for the investigation and explanation!

@kdy1 kdy1 self-assigned this Apr 10, 2025
@kdy1 kdy1 marked this pull request as ready for review April 10, 2025 15:54
@kdy1 kdy1 requested review from a team as code owners April 10, 2025 15:54
@kdy1 kdy1 merged commit eee73ce into main Apr 10, 2025
166 checks passed
@kdy1 kdy1 deleted the kdy1/revert-ci-fix branch April 10, 2025 15:54
@kdy1 kdy1 modified the milestones: Planned, v1.11.20 Apr 11, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators May 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants