Skip to content

fix(es/parser): Remove wrong check about const without init #9970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 29, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 28, 2025

@kdy1 kdy1 added this to the Planned milestone Jan 28, 2025
@kdy1 kdy1 self-assigned this Jan 28, 2025
@kdy1 kdy1 requested review from a team as code owners January 28, 2025 23:09
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 28, 2025
Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 9ca318a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 28, 2025
@kdy1 kdy1 enabled auto-merge (squash) January 28, 2025 23:14
Copy link

codspeed-hq bot commented Jan 29, 2025

CodSpeed Performance Report

Merging #9970 will degrade performances by 6.34%

Comparing kdy1:issue-9883 (514695d) with main (772cc30)

Summary

❌ 1 regressions
✅ 195 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/moment 97.8 ms 104.4 ms -6.34%

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 29, 2025
@kdy1 kdy1 merged commit 1b57261 into swc-project:main Jan 29, 2025
169 checks passed
@kdy1 kdy1 deleted the issue-9883 branch January 29, 2025 16:39
@kdy1 kdy1 modified the milestones: Planned, v1.10.12 Jan 29, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript does not throw at some invalid syntax.
1 participant