ESM compatibility: Fix crash on missing global env vars

[ttraenkler]

Fixes kv-asset-handler crashing when env vars are missing as is always the case with the new ESM module syntax which wraps those in an env object that is passed explicitly.

ReferenceError: __STATIC_CONTENT is not defined
ReferenceError: __STATIC_CONTENT_MANIFEST is not defined

This partially fixes the problems reported in #174, for the other half of the solution just wrap { request } and ts-ignore the typescript error to pass in the event object to getAssetFromKV. I did not do this change to stay backwards compatible until this is addressed properly by the Cloudflare team.

[evanderkoogh]

Yup.. doesn't solve the problem, but at least this makes it possible for anyone to solve it themselves.

We will need to figure out a separate proper solution that is backward-compatible.

[ttraenkler]

@evanderkoogh: Exactly! How the public API needs to change is best left to you but until then using this we can work around the issue. As mentioned in the PR if backwards compatibility is a requirement a new optional last env parameter for the affected functions could work - and if present it is used instead of the globals

[ttraenkler]

It seems actually that the __STATIC_CONTENT_MANIFEST is not included in the new env object anymore so without it the patch does not really work with assets uploaded with a hash as part of the filename as done by wrangler's workers-site code as of 1.16.1.

[Cherry]

Looks good to me. I'm not super familiar with ESM on Workers yet, but the change makes sense.

[lemonmade]

Would it be possible to get a release that includes this fix? Until this fix is released, I have to fork this library to use it in my worker project, but would love to use the real thing again :)

[kristianfreeman]

@Cherry we should release a new version this week :)

[Cherry]

@Cherry we should release a new version this week :)

💯 I'll shoot you a message