Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: firebase/firebase-admin-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v8.8.0
Choose a base ref
...
head repository: firebase/firebase-admin-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v8.9.0
Choose a head ref
  • 16 commits
  • 57 files changed
  • 6 contributors

Commits on Dec 2, 2019

  1. Eliminate duplicate BLACKLISTED_CLAIMS (#709)

    Requires exposing this constant so that the tests can use it.
    rsgowman authored Dec 2, 2019
    Configuration menu
    Copy the full SHA
    e231560 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Enable 'strictNullChecks' ts compiler option. (#676)

    * Enable 'structNullChecks' ts compiler option.
    
    In the majority of cases, I simply turned stuff like this:
    
    ```
    function fname(param: T) {
      if (!param) throw Error("invalid param; must not be nullish");
      ...
    }
    ```
    
    into this:
    
    ```
    function fname(param: T|null|undefined) {
      if (!param) throw Error("invalid param; must not be nullish");
      ...
    }
    ```
    
    A more sensible approach would be eliminate the possibility of
    null/undef and eliminate the checks too, but that's a bit more involved
    and this patch is already enormous. But I think these sorts of
    improvements could be taken advantage of opportunistically as the code
    is worked on in the future.
    
    * Add @firebase/auth-types to dev dependencies
    
    And also update @firebase/auth to most recent to match.
    rsgowman authored Dec 6, 2019
    Configuration menu
    Copy the full SHA
    45905e4 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Configuration menu
    Copy the full SHA
    375c4fb View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Upgraded Typescript to 3.7.x (#720)

    * Upgraded Typescript to 3.7.x
    
    * Removing typeof
    
    * Made pollCallback optional
    hiranya911 authored Dec 10, 2019
    Configuration menu
    Copy the full SHA
    bba61e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Configuration menu
    Copy the full SHA
    ed98926 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0013c06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8104b90 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d9ff20e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Configuration menu
    Copy the full SHA
    a9249a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Using async project ID discovery API in Auth and FCM (#724)

    * Using async project ID discovery API in Auth and FCM
    
    * Fixed indentation
    hiranya911 authored Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a18dc71 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Using async project ID discovery in ProjectManagement and InstanceId (#…

    …728)
    
    * Using async project ID discovery API in Auth and FCM
    
    * Async project ID discovery mechanism for ProjectManagement and InstanceId APIs
    hiranya911 authored Dec 16, 2019
    Configuration menu
    Copy the full SHA
    050cc59 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99d3214 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Configuration menu
    Copy the full SHA
    d3f3d91 View commit details
    Browse the repository at this point in the history
  2. feat: Update Firestore to 3.0 (#735)

    * Update Firestore to 3.0
    
    This is not intended to be merged, I just want to make it possible to install Firebase Admin + Firestore from a branch.
    
    * Update package-lock.json
    schmidt-sebastian authored and hiranya911 committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    29e3f06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    513f3ac View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. Configuration menu
    Copy the full SHA
    00892e0 View commit details
    Browse the repository at this point in the history
Loading