Skip to content

fix: Return type any from createReduxEnhancer to avoid type conflicts #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2020
Merged

fix: Return type any from createReduxEnhancer to avoid type conflicts #2834

merged 1 commit into from
Aug 21, 2020

Conversation

jennmueng
Copy link
Member

@jennmueng jennmueng commented Aug 21, 2020 •
edited by HazAT
Loading

Return an any type instead for Sentry.createReduxEnhancer exported from @sentry/redux to avoid type conflicts.

Fixes #2829

@jennmueng jennmueng force-pushed the jenn/fix-redux-types branch from 73dae82 to 676695c Compare August 21, 2020 14:48
@github-actions
Copy link
Contributor

github-actions bot commented Aug 21, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.67 KB (0%)
@sentry/browser - Webpack 18.46 KB (0%)
@sentry/react - Webpack 18.46 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.69 KB (-0.32% 🔽)

@HazAT HazAT merged commit b13b2e5 into master Aug 21, 2020
@HazAT HazAT deleted the jenn/fix-redux-types branch August 21, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HazAT HazAT HazAT approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

StoreEnhancer does not when using Redux toolkit

3 participants

@jennmueng @HazAT @AbhiPrasad