Skip to content

Changes required for updated api-common #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 18, 2017

Conversation

michaelbausor
Copy link
Contributor

Tests currently failing because grpc packages need to be released with updated api-common

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 17, 2017
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it would be ideal to sort the imports, but we're going to clean that up in an automated way later anyway.

import com.google.api.gax.core.FlowControlSettings;
import com.google.api.gax.core.FlowController;
import com.google.api.gax.core.RetrySettings;
import com.google.api.gax.core.SettableApiFuture;
import com.google.api.core.SettableApiFuture;

This comment was marked as spam.

This comment was marked as spam.

@garrettjonesgoogle
Copy link
Member

The updates LGTM

@michaelbausor michaelbausor changed the title WIP: Changes required for updated api-common Changes required for updated api-common Apr 18, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f128868 on michaelbausor:guava-update into ** on GoogleCloudPlatform:master**.

@michaelbausor michaelbausor merged commit d476ef7 into googleapis:master Apr 18, 2017
@michaelbausor michaelbausor deleted the guava-update branch April 18, 2017 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants