Remove project id requirement for creating a GCS client. #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s only required for creating buckets, not operating on them, so it doesn't make sense to make it required for all cases.
googlebot
added
the
cla: yes
shinfan
approved these changes
May 9, 2017
anuraaga
changed the title
|
@shinfan Shortened the PR title, though feel free to edit it further as you see fit. Don't have write access so will need someone to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Project id is only required for creating buckets, not operating on them, so it doesn't make sense to make it required for all cases.
I currently have some code that only operates on an existing bucket, and literally set the project id to "devnull" to prevent users from having to provide a valid project id which is not necessary.