Skip to content

add-max-retry-property-support #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 18, 2017
Merged

add-max-retry-property-support #2062

merged 4 commits into from
May 18, 2017

Conversation

AntonZarutsky
Copy link

@AntonZarutsky AntonZarutsky commented May 15, 2017 •
edited
Loading

RetrySettings contain property maxAttempt which is not used by Publisher.
Added support for maxAttempt, which gives developer control a bit more over retries.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 779f526 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 779f526 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

@garrettjonesgoogle garrettjonesgoogle requested a review from pongad May 16, 2017 15:42
pongad
pongad reviewed May 16, 2017
View reviewed changes
Copy link
Contributor

@pongad pongad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Some style comments, but otherwise LGTM.

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/spi/v1/PublisherImplTest.java Outdated
@@ -343,6 +420,8 @@ public void testPublishFailureRetries_nonRetryableFailsImmediately() throws Exce
}
}



This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/spi/v1/Publisher.java Outdated
import io.grpc.ManagedChannel;
import io.grpc.Status;
import org.threeten.bp.Duration;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 00582b8 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

@AntonZarutsky AntonZarutsky reopened this May 17, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 49b4e32 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 49b4e32 on AntonZarutsky:add-max-retry-property-support into ** on GoogleCloudPlatform:master**.

@pongad pongad merged commit 97f6164 into googleapis:master May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pongad pongad pongad left review comments

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonZarutsky @coveralls @pongad @googlebot