Creating google-cloud-compat-checker #2317
Conversation
googlebot
added
the
cla: yes
|
Changes Unknown when pulling 214089d on garrettjonesgoogle:master into ** on GoogleCloudPlatform:master**. |
|
|
||
| @Override | ||
| protected void log(String s) { | ||
| // meh |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google-cloud-compat-checker/pom.xml
Outdated
| <!-- It may look weird to have a compile dependency on a plugin, | ||
| but we want to execute code from it at runtime, in order | ||
| to not duplicate the logic ourselves --> | ||
| <groupId>kr.motd.maven</groupId> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -0,0 +1,25 @@ | |||
| Google Cloud Java Compatibility Checker | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Moved the compat checker under google-cloud-util, PTAL |
|
I'm not sure what you mean by the "purpose" section, because I don't see a section named that in (for example) the root README and the google-cloud-logging README. |
|
I meant some (optional) description in readme of what this module is about, since for utility modules it is not that clear. It doesn't have to be called "purpose". |
So far I am just bootstrapping this to check os & architecture. There is a lot more we could check, which we can add later.
Currently, users have to build this themselves, because there have been no releases of it yet. Later, we can switch the instructions to use the maven artifact somehow.
I intend to use this to diagnose #2266 .