Fixing retries of Storage.create #2359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
vam-google
approved these changes
Aug 18, 2017
| Map<StorageRpc.Option, ?> optionsMap = optionMap(targetOptions.x(), targetOptions.y()); | ||
| InputStream inputStreamParam = firstNonNull(content, new ByteArrayInputStream(EMPTY_BYTE_ARRAY)); | ||
| // retries are not safe when the input is an InputStream, so we can't retry. | ||
| return Blob.fromPb(this, storageRpc.create(blobPb, inputStreamParam, optionsMap)); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1460,6 +1463,7 @@ public static Builder newBuilder() { | |||
| * @return a [@code Blob} with complete information | |||
| * @throws StorageException upon failure | |||
| */ | |||
| @Deprecated | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
So for now we're not supposed to use it and are required to either load everything into RAM or write a lot of boilerplate? |
|
Ping @garrettjonesgoogle and @andreamlin for user feedback on this PR. Is there a plan to introduce |
|
I have filed #2620 to track the work of introducing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blob create(BlobInfo blobInfo, InputStream content, BlobWriteOption... options): Turning off retries and marking@Deprecated, because once theInputStreamhas been consumed, it can't be consumed again.Blob create(BlobInfo blobInfo, byte[] content, BlobTargetOption... options): Re-creating theInputStreamon every call, so that the same data is resent to the server.