Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.7.2
Choose a base ref
...
head repository: ionic-team/ionic-framework
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.7.3
Choose a head ref
  • 7 commits
  • 49 files changed
  • 3 contributors

Commits on Feb 14, 2024

  1. Configuration menu
    Copy the full SHA
    76c003a View commit details
    Browse the repository at this point in the history
  2. merge release-7.2.2

    Release 7.7.2
    liamdebeasi authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    7033a28 View commit details
    Browse the repository at this point in the history
  3. chore(deps): update actions/checkout action to v4 (#29047)

    [![Mend
    Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [actions/checkout](https://togithub.com/actions/checkout) | action |
    major | `v3` -> `v4` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>actions/checkout (actions/checkout)</summary>
    
    ###
    [`v4`](https://togithub.com/actions/checkout/blob/HEAD/CHANGELOG.md#v400)
    
    [Compare Source](https://togithub.com/actions/checkout/compare/v3...v4)
    
    - [Support fetching without the --progress
    option](https://togithub.com/actions/checkout/pull/1067)
    -   [Update to node20](https://togithub.com/actions/checkout/pull/1436)
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - "every weekday before 11am" (UTC),
    Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you
    are satisfied.
    
    ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update
    again.
    
    ---
    
    - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
    this box
    
    ---
    
    This PR has been generated by [Mend
    Renovate](https://www.mend.io/free-developer-tools/renovate/). View
    repository job log
    [here](https://developer.mend.io/github/ionic-team/ionic-framework).
    
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE3My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
    
    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6b781fb View commit details
    Browse the repository at this point in the history
  4. fix(label): do not grow when in end slot (#29036)

    Issue number: resolves #29033
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    In #28773 I resolved
    several incorrect behaviors with Items related to text wrapping.
    However, it looks like I missed the removal of
    https://github.com/ionic-team/ionic-framework/pull/28146/files#diff-4a1156704dbf45b0dad273b6909b190ca45e4380aa7378ba88d0dd7d48d7d473R37
    which caused the issue to persist when adding a label to the end slot.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - Removed logic that caused `ion-label` to grow larger than it needed to
    be
    
    | `main` | branch |
    | - | - |
    | ![Screenshot 2024-02-13 at 11 20
    43 AM](https://github.com/ionic-team/ionic-framework/assets/2721089/3fbddd04-d4b5-474c-ab9c-4d9c6e88f758)
    | ![Screenshot 2024-02-13 at 11 21
    17 AM](https://github.com/ionic-team/ionic-framework/assets/2721089/188eda24-ec6f-4ba7-b3ed-2993d93b1cc7)
    |
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    Dev build: `7.7.2-dev.11707840956.16e27b4c`
    
    ---------
    
    Co-authored-by: ionitron <[email protected]>
    liamdebeasi and Ionitron authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    1fc4b76 View commit details
    Browse the repository at this point in the history
  5. fix(overlays): focus is returned to last focus element when focusing …

    …toast (#28950)
    
    Issue number: resolves #28261
    
    ---------
    
    <!-- Please do not submit updates to dependencies unless it fixes an
    issue. -->
    
    <!-- Please try to limit your pull request to one type (bugfix, feature,
    etc). Submit multiple pull requests if needed. -->
    
    ## What is the current behavior?
    <!-- Please describe the current behavior that you are modifying. -->
    
    When moving focus from a focus-trapped overlay to a toast, focus is
    moved back to the overlay. This is the correct behavior as focus should
    never leave a focus-trapped overlay (unless the overlay is dismissed or
    focus is moved to a _new_ top-most overlay). However, the way we return
    focus is a bit unexpected because it always returns focus to the last
    focusable element in the overlay.
    
    This means that if you were focused on the first focusable element,
    presented the toast, and then focused the toast, focus might not be
    moved back to that first focusable element. In the case of the linked
    issue, this was causing an unexpected scroll so that the last focused
    element could be in view.
    
    ## What is the new behavior?
    <!-- Please describe the behavior or changes that are being added by
    this PR. -->
    
    - This fix adds an exception for `ion-toast` (as it is the only overlay
    that is **not** focus trapped) that ensures that focus is moved back to
    the last focus element.
    
    ## Does this introduce a breaking change?
    
    - [ ] Yes
    - [x] No
    
    <!--
      If this introduces a breaking change:
    1. Describe the impact and migration path for existing applications
    below.
      2. Update the BREAKING.md file with the breaking change.
    3. Add "BREAKING CHANGE: [...]" to the commit description when merging.
    See
    https://github.com/ionic-team/ionic-framework/blob/main/.github/CONTRIBUTING.md#footer
    for more information.
    -->
    
    
    ## Other information
    
    <!-- Any other information that is important to this PR such as
    screenshots of how the component looks before and after the change. -->
    
    
    Dev build: `7.7.1-dev.11707253408.186eea70`
    
    Note: We don't recommend this pattern in general because it would be
    impossible for a screen reader user to focus the toast. However, we can
    at least improve the experience for developers who continue to implement
    this pattern by returning focus in a more predictable manner.
    
    Docs: ionic-team/ionic-docs#3432
    
    Testing: 
    
    Reviewers should manually test the following behaviors:
    
    1. Create a modal with 2 buttons. Have one of the buttons present a
    toast. Open the toast and verify that you can still Tab to cycle through
    the buttons in the modal.
    2. Create a modal with 2 buttons. Have one of the buttons present a
    toast. Open the toast. Move focus to the toast and verify that you can
    still Tab to cycle through the buttons in the modal (once focus is
    returned to the modal).
    liamdebeasi authored Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2ed0ada View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. chore: remove liam from auto-assign issues while out of office (#29066)

    This removes me from being auto-assigned issues while I am out of
    office.
    liamdebeasi authored Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7ec17af View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. v7.7.3

    Ionitron committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    3fd66e7 View commit details
    Browse the repository at this point in the history
Loading