Enhance VSSDK001 code fix to migrate to AsyncPackage more completely #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That test would be awesome to support, but there are so many variants of syntax for AddService that would have to be upgraded, including lambdas, delegates, method groups, etc., that claiming to accomplish it would be a mammoth effort.
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 92.25% 93.43% +1.17%
==========================================
Files 7 7
Lines 284 335 +51
==========================================
+ Hits 262 313 +51
Misses 22 22
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VSSDK001 code fix now also:
PackageRegistrationAttribute.AllowBackgroundLoadingpropertyGetServicecalls that were in the oldInitializeoverride withGetServiceAsynccalls in the newInitializeAsyncoverride.I also remove a test as a wave of the white flag against the goal of updating all the
IServiceContainer.AddServicecalls in theInitializemethod to use the async service container. So many variants of how the syntax might look -- it's possible, but would be a ton of work so I'll wait for feedback to justify doing it.