Fix @param-out on methods

Author: staabm

src/Reflection/Type/CallbackUnresolvedMethodPrototypeReflection.php

@@ -7,8 +7,10 @@
 use PHPStan\Reflection\ExtendedMethodReflection;
 use PHPStan\Reflection\FunctionVariant;
 use PHPStan\Reflection\ParameterReflection;
+use PHPStan\Reflection\ParameterReflectionWithPhpDocs;
 use PHPStan\Reflection\ParametersAcceptor;
 use PHPStan\Reflection\Php\DummyParameter;
+use PHPStan\Reflection\Php\DummyParameterWithPhpDocs;
 use PHPStan\Reflection\ResolvedMethodReflection;
 use PHPStan\Type\Type;
 use function array_map;
@@ -83,14 +85,33 @@ private function transformMethodWithStaticType(ClassReflection $declaringClass,
 		$variants = array_map(fn (ParametersAcceptor $acceptor): ParametersAcceptor => new FunctionVariant(
 			$acceptor->getTemplateTypeMap(),
 			$acceptor->getResolvedTemplateTypeMap(),
-			array_map(fn (ParameterReflection $parameter): ParameterReflection => new DummyParameter(
-				$parameter->getName(),
-				$this->transformStaticType($parameter->getType()),
-				$parameter->isOptional(),
-				$parameter->passedByReference(),
-				$parameter->isVariadic(),
-				$parameter->getDefaultValue(),
-			), $acceptor->getParameters()),
+			array_map(
+				function (ParameterReflection $parameter): ParameterReflection {
+					if ($parameter instanceof ParameterReflectionWithPhpDocs) {
+						return new DummyParameterWithPhpDocs(
+							$parameter->getName(),
+							$this->transformStaticType($parameter->getType()),
+							$parameter->isOptional(),
+							$parameter->passedByReference(),
+							$parameter->isVariadic(),
+							$parameter->getDefaultValue(),
+							$parameter->getNativeType(),
+							$parameter->getPhpDocType(),
+							$parameter->getOutType(),
+						);
+					}
+
+					return new DummyParameter(
+						$parameter->getName(),
+						$this->transformStaticType($parameter->getType()),
+						$parameter->isOptional(),
+						$parameter->passedByReference(),
+						$parameter->isVariadic(),
+						$parameter->getDefaultValue(),
+					);
+				},
+				$acceptor->getParameters(),
+			),
 			$acceptor->isVariadic(),
 			$this->transformStaticType($acceptor->getReturnType()),
 		), $method->getVariants());

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -1132,6 +1132,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8361.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8373.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/Functions/data/bug-8389.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8421.php');
 	}
 
 	/**

tests/PHPStan/Analyser/data/bug-8421.php

@@ -0,0 +1,16 @@
+<?php declare(strict_types = 1);
+
+namespace Bug8421;
+
+use function PHPStan\Testing\assertType;
+
+final class Foo {
+	/** @param-out int $i */
+	final public function foo(mixed &$i): void {
+		$i = 5;
+	}
+	final public function bar(): void {
+		$this->foo($a);
+		assertType('int', $a);
+	}
+}