Fix mt_rand return type

Author: enumag

src/Type/Php/RandomIntFunctionReturnTypeExtension.php

@@ -23,12 +23,12 @@ class RandomIntFunctionReturnTypeExtension implements DynamicFunctionReturnTypeE
 
 	public function isFunctionSupported(FunctionReflection $functionReflection): bool
 	{
-		return in_array($functionReflection->getName(), ['random_int', 'rand'], true);
+		return in_array($functionReflection->getName(), ['random_int', 'rand', 'mt_rand'], true);
 	}
 
 	public function getTypeFromFunctionCall(FunctionReflection $functionReflection, FuncCall $functionCall, Scope $scope): Type
 	{
-		if ($functionReflection->getName() === 'rand' && count($functionCall->getArgs()) === 0) {
+		if (in_array($functionReflection->getName(), ['rand', 'mt_rand'], true) && count($functionCall->getArgs()) === 0) {
 			return IntegerRangeType::fromInterval(0, null);
 		}
 

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -1121,6 +1121,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/closure-retain-expression-types.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7913.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/Functions/data/bug-8280.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-8272.php');
 	}
 
 	/**

tests/PHPStan/Analyser/data/bug-4091.php

@@ -6,5 +6,5 @@
 
 if (mt_rand(0,10) > 3) {
 	echo 'Fizz';
-	assertType('int', mt_rand(0,10));
+	assertType('int<0, 10>', mt_rand(0,10));
 }

tests/PHPStan/Analyser/data/bug-8272.php

@@ -0,0 +1,10 @@
+<?php
+
+namespace Bug8272;
+
+use function PHPStan\Testing\assertType;
+
+function test(): void {
+	assertType('int<1, 5>', mt_rand(1, 5));
+	assertType('int<0, max>', mt_rand());
+};