Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/java-spanner
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.49.0
Choose a base ref
...
head repository: googleapis/java-spanner
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.49.1
Choose a head ref
  • 11 commits
  • 188 files changed
  • 6 contributors

Commits on Jan 17, 2020

  1. Configuration menu
    Copy the full SHA
    384ddb4 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2020

  1. fix: stop sending RPCs to deleted database (#34)

    * fix: stop sending rpcs on deleted db
    
    * fix: client should stop sending rpcs after database dropped
    
    DatabaseClients should not continue to try to send RPCs to a database that has
    been deleted. Instead, the session pool will keep track of whether a database
    not found error has been returned for a database, and if so, will invalidate
    itself. All subsequent calls for this database will return a DatabaseNotFoundException
    without calling a RPC.
    
    If a database is re-created, the user must create a new DatabaseClient with a new
    session pool in order to resume usage of the database.
    
    Fixes #16
    
    * fix: remove double check on isValid
    
    * fix: add wait to deleted db integration test
    
    * fix: process review comments
    
    * fix: update copyright year
    olavloite authored Jan 22, 2020
    Configuration menu
    Copy the full SHA
    11e4a90 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2020

  1. perf: close sessions async (#24)

    * perf: close sessions async
    
    Sessions should be closed using an async gRPC call in order
    to speed up the closing of a large session pool. Instead of
    using its own executor, which is limited to 8 worker threads,
    to execute asynchronous delete session calls, the session pool
    should use the asynchronous call option in gRPC. This allows a
    larger number of asynchronous delete session calls to be executed
    in parallel and speeds up closing a session pool with a large
    number of sessions.
    
    Testing against a real Cloud Spanner database with a session pool
    containing 1,000 sessions shows the following performance for
    closing the session pool:
    
    Before (3 runs):
    6603ms
    8169ms
    8367ms
    
    After (3 runs):
    1297ms
    1710ms
    1851ms
    
    Fixes #19.
    
    * fix: wait for test servers to terminate
    
    * remove tracing for async call
    
    * do not use directExecutor which could be a gRPC thread
    
    * fix: return failed future instead of throwing exception
    
    * fix: remove commented code
    olavloite authored and skuruppu committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    ab25087 View commit details
    Browse the repository at this point in the history
  2. chore: release 1.49.1-SNAPSHOT (#39)

    * updated versions.txt [ci skip]
    
    * updated google-cloud-spanner-bom/pom.xml [ci skip]
    
    * updated google-cloud-spanner/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip]
    
    * updated pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-v1/pom.xml [ci skip]
    release-please[bot] authored and skuruppu committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    e477af0 View commit details
    Browse the repository at this point in the history
  3. test: [WIP] add Commit Timestamp java integration tests for cloud spa…

    …nner (#37)
    
    * test: add Commit Timestamp java integration tests for cloud spanner
    
    * Use org.threeten.bp library instead of java.time for Java 7 compatibility
    
    * test: Fix java comment documentation style to use @test annotation right before function name
    
    * Fix formatting error in imports
    agasheesh authored and skuruppu committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5a4fc74 View commit details
    Browse the repository at this point in the history
  4. Revert "perf: close sessions async (#24)" (#43)

    This reverts commit ab25087.
    skuruppu authored and hengfengli committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    809ed88 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8b07084 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2020

  1. chore: remove deprecated registration of the span names for zpages (#27)

    * replace deprecated registration of the span names for zpages
    
    * remove unused END_SPAN_OPTIONS
    
    * fix test
    mayurkale22 authored and skuruppu committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    b619fed View commit details
    Browse the repository at this point in the history
  2. perf: close sessions async revert revert (#46)

    * Revert "Revert "perf: close sessions async (#24)" (#43)"
    
    This reverts commit 809ed88.
    
    * Ignore compatibility check failure in internal interfaces.
    
    asyncClose() was added to com.google.cloud.spanner.Session and
    asyncDeleteSession() was added to
    com.google.cloud.spanner.spi.v1.SpannerRpc in #24 which resulted in
    binary compatibility test failures. This config allows us to ignore the
    failure.
    
    * Annotate SpannerRpc and Session classes as @internalapi.
    
    Users shouldn't be implementing these interfaces as they're internal to
    the client library implementation.
    skuruppu authored and olavloite committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    c9864e5 View commit details
    Browse the repository at this point in the history
  3. test: fix flaky integration test (#45)

    The ITClosedSessionTest could cause a flaky failure because it
    deletes sessions on the server and then repeatedly executes queries
    on the session until it returns a NOT_FOUND error. The actual deletion
    could however happen exactly at the moment that the test query was
    executed, which will cause Cloud Spanner to return a different error
    message than the standard 'Session not found' error message.
    
    Fixes #41
    olavloite authored Jan 24, 2020
    Configuration menu
    Copy the full SHA
    0702b20 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. chore: release 1.49.1 (#42)

    * updated google-cloud-spanner/pom.xml [ci skip]
    
    * updated CHANGELOG.md [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated README.md [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated versions.txt [ci skip]
    
    * updated google-cloud-spanner-bom/pom.xml [ci skip]
    
    * updated google-cloud-spanner/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip]
    
    * updated pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-v1/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated grpc-google-cloud-spanner-v1/pom.xml [ci skip]
    
    * updated pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-database-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-admin-instance-v1/pom.xml [ci skip]
    
    * updated proto-google-cloud-spanner-v1/pom.xml [ci skip]
    release-please[bot] authored and skuruppu committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    933effa View commit details
    Browse the repository at this point in the history
Loading