Bug 1132 - Avoid misleading for loops with no body.
authorMirko Banchi <mk.banchi@gmail.com>
Wed, 16 Sep 2015 23:34:51 +0200
changeset 11671 4ef2a0434d99
parent 11670 28a8a46fbb98
child 11672 1905dcc9d4ef
Bug 1132 - Avoid misleading for loops with no body.
src/wifi/test/block-ack-test-suite.cc
--- a/src/wifi/test/block-ack-test-suite.cc	Tue Sep 15 16:13:22 2015 -0700
+++ b/src/wifi/test/block-ack-test-suite.cc	Wed Sep 16 23:34:51 2015 +0200
@@ -97,21 +97,29 @@
 
   uint16_t receivedSeq = 4001 * 16;
   uint32_t mappedSeq = QosUtilsMapSeqControlToUniqueInteger (receivedSeq, endSeq);
-  for (i = m_buffer.begin (); i != m_buffer.end () && QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) < mappedSeq; i++)
+  /* cycle to right position for this packet */
+  for (i = m_buffer.begin (); i != m_buffer.end (); i++)
     {
+      if (QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) >= mappedSeq)
+        {
+          //position found
+          break;
+        }
     }
-  {
-    m_buffer.insert (i, receivedSeq);
-  }
+  m_buffer.insert (i, receivedSeq);
 
   receivedSeq = 3999 * 16;
   mappedSeq = QosUtilsMapSeqControlToUniqueInteger (receivedSeq, endSeq);
-  for (i = m_buffer.begin (); i != m_buffer.end () && QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) < mappedSeq; i++)
+  /* cycle to right position for this packet */
+  for (i = m_buffer.begin (); i != m_buffer.end (); i++)
     {
+      if (QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) >= mappedSeq)
+        {
+          //position found
+          break;
+        }
     }
-  {
-    m_buffer.insert (i, receivedSeq);
-  }
+  m_buffer.insert (i, receivedSeq);
 
   for (i = m_buffer.begin (), j = m_expectedBuffer.begin (); i != m_buffer.end (); i++, j++)
     {
@@ -181,30 +189,42 @@
 
   uint16_t receivedSeq = 15 * 16;
   uint32_t mappedSeq = QosUtilsMapSeqControlToUniqueInteger (receivedSeq, endSeq);
-  for (i = m_buffer.begin (); i != m_buffer.end () && QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) < mappedSeq; i++)
+  /* cycle to right position for this packet */
+  for (i = m_buffer.begin (); i != m_buffer.end (); i++)
     {
+      if (QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) >= mappedSeq)
+        {
+          //position found
+          break;
+        }
     }
-  {
-    m_buffer.insert (i, receivedSeq);
-  }
+  m_buffer.insert (i, receivedSeq);
 
   receivedSeq = 15 * 16 + 1;
   mappedSeq = QosUtilsMapSeqControlToUniqueInteger (receivedSeq, endSeq);
-  for (i = m_buffer.begin (); i != m_buffer.end () && QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) < mappedSeq; i++)
+  /* cycle to right position for this packet */
+  for (i = m_buffer.begin (); i != m_buffer.end (); i++)
     {
+      if (QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) >= mappedSeq)
+        {
+          //position found
+          break;
+        }
     }
-  {
-    m_buffer.insert (i, receivedSeq);
-  }
+  m_buffer.insert (i, receivedSeq);
 
   receivedSeq = 4050 * 16;
   mappedSeq = QosUtilsMapSeqControlToUniqueInteger (receivedSeq, endSeq);
-  for (i = m_buffer.begin (); i != m_buffer.end () && QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) < mappedSeq; i++)
+  /* cycle to right position for this packet */
+  for (i = m_buffer.begin (); i != m_buffer.end (); i++)
     {
+      if (QosUtilsMapSeqControlToUniqueInteger ((*i), endSeq) >= mappedSeq)
+        {
+          //position found
+          break;
+        }
     }
-  {
-    m_buffer.insert (i, receivedSeq);
-  }
+  m_buffer.insert (i, receivedSeq);
 
   for (i = m_buffer.begin (), j = m_expectedBuffer.begin (); i != m_buffer.end (); i++, j++)
     {