Skip to content

desktop-base: reset nullglob to off after xdg-data-dirs-opt-apps.sh #11400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

MingcongBai
Copy link
Member

@MingcongBai MingcongBai commented Jun 17, 2025

Topic Description

  • desktop-base: reset nullglob to off after xdg-data-dirs-opt-apps.sh
    This option, when enabled, would cause the asterisk/glob marker to be
    ignored if no match is found. This resulted in a very confusing behaviour
    with ls(1), where `ls *random-nonexistent*' would be treated as equivalent
    to `ls' with no parameter at all.
    Make sure to unset this shell option after whatever was done in
    xdg-data-dirs-opt-apps.sh.
    Link: https://www.gnu.org/software/bash/manual/html_node/Filename-Expansion.html

Package(s) Affected

  • desktop-base: 16

Security Update?

No

Build Order

#buildit desktop-base

Test Build(s) Done

Primary Architectures

  • AMD64 amd64
  • AArch64 arm64
  • LoongArch 64-bit loongarch64

Secondary Architectures

  • Loongson 3 loongson3
  • PowerPC 64-bit (Little Endian) ppc64el
  • RISC-V 64-bit riscv64

This option, when enabled, would cause the asterisk/glob marker to be
ignored if no match is found. This resulted in a very confusing behaviour
with ls(1), where `ls *random-nonexistent*' would be treated as equivalent
to `ls' with no parameter at all.

Make sure to unset this shell option after whatever was done in
xdg-data-dirs-opt-apps.sh.

Link: https://www.gnu.org/software/bash/manual/html_node/Filename-Expansion.html
@MingcongBai MingcongBai marked this pull request as ready for review June 17, 2025 05:44
Copy link
Member

@Cyanoxygen Cyanoxygen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

Before:
image

After:
image

@MingcongBai MingcongBai merged commit 99cd109 into stable Jun 17, 2025
6 checks passed
@MingcongBai MingcongBai deleted the desktop-base-reset-nullglob branch June 17, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants