Changes to support ISO date format while deserializing #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krraghavan
reviewed
Mar 9, 2024
|
|
||
| TestDateBean bean3 = new TestDateBean(); | ||
| bean3.setDate(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").parse("2014-04-04T21:23:13.331Z")); | ||
| bean3.setItem("abc"); |
|
|
||
| TestDateBean bean2 = new TestDateBean(); | ||
| bean2.setDate(new Date()); | ||
| bean2.setItem("abc"); |
| public void mustDeserializeBothISOAndMillisForDate() throws ParseException { | ||
| assertNotNull(testDateRepository); | ||
| TestDateBean bean1 = new TestDateBean(); | ||
| bean1.setDate(new SimpleDateFormat("yyyy-MM-dd'T'HH:mm'Z'").parse("2024-03-09T00:10Z")); |
There was a problem hiding this comment.
Use current time to generate date instead of hard coded date time values
| @@ -75,6 +74,35 @@ public void mustCreateMatchAggregationOperation() { | |||
| assertNotNull(result); | |||
| } | |||
|
|
|||
| @Test | |||
| public void mustDeserializeBothISOAndMillisForDate() throws ParseException { | |||
There was a problem hiding this comment.
Make these into parameterized test. Rather than having multiple scenarios in one test.
| bean3.setItem("abc"); | ||
| bean3.set_id(UUID.randomUUID().toString()); | ||
|
|
||
| List<TestDateBean> beans = new ArrayList<>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.