-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
refactor: deeplink handler #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request refactors the deep link handling mechanism to support different deep link schemas. It introduces a No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @LucasXu0 - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider making the DeepLinkHandlerRegistry a singleton to ensure consistent handling of deep links across the application.
- The canHandle methods in DeepLinkHandler implementations could benefit from additional validation of the URI parameters.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
frontend/appflowy_flutter/lib/startup/tasks/deeplink/deeplink_handler.dart
Show resolved
Hide resolved
f540467
to
4c55a55
Compare
d90149a
to
c8e2811
Compare
Feature Preview
PR Checklist
Summary by Sourcery
Refactor the deeplink handling system to support multiple deeplink schemas with a more modular and extensible approach
New Features:
Enhancements: