Skip to content

chore: fix anon #7806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2025
Merged

chore: fix anon #7806

merged 8 commits into from
Apr 23, 2025

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented Apr 22, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Refactor user session initialization and authentication logic to simplify and improve error handling in the user management process

Bug Fixes:

  • Fixed an issue with user session retrieval by adjusting error handling when no session is found

Enhancements:

  • Simplified user session initialization by removing redundant user profile retrieval
  • Improved logging for user session initialization
  • Streamlined token and authentication type handling

Chores:

  • Cleaned up user authentication and session management code

Copy link
Contributor

sourcery-ai bot commented Apr 22, 2025

Reviewer's Guide by Sourcery

This pull request enhances user session management by improving logging, simplifying token handling, and correcting error codes. It also modifies the slash menu to always show AI options.

Sequence diagram for user session initialization

sequenceDiagram
  participant UserManager
  participant CloudService
  participant AuthenticateUser
  participant Database

  UserManager->>UserManager: get_session()
  alt Session exists
    UserManager->>UserManager: token_from_auth_type(auth_type)
    UserManager->>CloudService: set_server_auth_type(auth_type, token)
    UserManager->>CloudService: subscribe_token_state()
    CloudService-->>UserManager: token_state_rx
    UserManager->>Database: db_pool(user_id)
    UserManager->>AuthenticateUser: get_user_collab_db()
    UserManager->>Database: db_connection(user_id)
    UserManager->>Database: select_user_auth_type(user_id)
    UserManager->>AuthenticateUser: get_user_sqlite_db()
    UserManager->>UserManager: run_data_migration()
    UserManager->>UserManager: user_status_callback.on_launch_if_authenticated()
  else No session exists
    UserManager-->>UserManager: Error
  end
Loading

Updated class diagram for AuthenticateUser

classDiagram
class AuthenticateUser {
    -user_config: UserConfig
    +new()
    +authenticate()
    +register()
    +reset_password()
    +verify_email()
    +get_session()
    +clear_session()
    +get_user_collab_db()
    +get_user_sqlite_db()
}

note for AuthenticateUser "Manages user authentication and session data."
Loading

File-Level Changes

Change Details Files
Improved user session initialization by logging session details, setting server authentication type, and handling token subscriptions for AppFlowy Cloud.
  • Logged user session details including user ID, workspace name, and workspace ID.
  • Set the server authentication type based on the workspace type.
  • Implemented token subscription for AppFlowy Cloud to handle token state changes.
  • Simplified token handling by using workspace type instead of user auth type.
  • Removed redundant user profile retrieval from disk.
frontend/rust-lib/flowy-user/src/user_manager/manager.rs
Corrected session retrieval error code and removed local mode check for AI slash menu items.
  • Changed the error code returned when a user session is not found from RecordNotFound to UserUnauthorized.
  • Removed the isLocalMode check for displaying AI-related slash menu items.
frontend/rust-lib/flowy-user/src/services/authenticate_user.rs
frontend/appflowy_flutter/lib/plugins/document/presentation/editor_plugins/slash_menu/slash_menu_items_builder.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider extracting the token subscription logic into a separate function for better readability.
  • The isLocalMode check was removed from the slash menu items, is that intentional?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

github-actions bot commented Apr 22, 2025

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 29 warning contribute (via Fink 🐦)

@appflowy appflowy merged commit 4067eea into main Apr 23, 2025
17 of 19 checks passed
@appflowy appflowy deleted the fix_anon_open branch April 23, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants