Skip to content

feat: support invite member by link on mobile #7811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 24, 2025

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Apr 23, 2025

Feature Preview

  • update user avatar style in members page
  • invitation link error
  • disable logs in test

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Fix invitation link generation and improve user interface elements

Bug Fixes:

  • Resolve invitation link generation by adding validation for empty invite codes
  • Improve error handling for invite code retrieval

Enhancements:

  • Update user avatar styling to use theme-based text styling
  • Modify log disabling mechanism for test environments

Copy link
Contributor

sourcery-ai bot commented Apr 23, 2025

Reviewer's Guide by Sourcery

This pull request addresses issues with invitation links, updates the user avatar style, and disables logs during testing. The invitation link error was fixed by correctly parsing the 'code' from the API response. The user avatar style was updated to align with the new UI library. Logging was disabled in test mode to reduce noise during testing.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Fixed an issue where the invitation link was not correctly extracted from the API response.
  • Updated the code to correctly parse the 'code' from the 'data' field in the API response.
  • Added a check to ensure the 'code' is not empty and returns an error if it is.
frontend/appflowy_flutter/lib/workspace/presentation/settings/widgets/members/inivitation/member_http_service.dart
Updated the user avatar style to use the new UI library.
  • Replaced FlowyText with Text and applied styles from AppFlowyTheme.
  • Updated the color scheme to use theme.textColorScheme.primary.
frontend/appflowy_flutter/lib/workspace/presentation/widgets/user_avatar.dart
Disabled logs in test mode.
  • Added a condition to disable logging when the app is running in test mode.
  • Moved the disableLog flag to the Log class.
frontend/appflowy_flutter/lib/startup/startup.dart
frontend/appflowy_flutter/packages/appflowy_backend/lib/log.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a more specific error message to the invitation code failure case.
  • It's great that you're disabling logs in test mode, but make sure this doesn't interfere with debugging test failures.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 force-pushed the invite_link_issues branch from a1b7fdf to 4eb122c Compare April 23, 2025 06:14
@LucasXu0 LucasXu0 changed the title fix: invitation link issues feat: support invite member by link on mobile Apr 23, 2025
@LucasXu0 LucasXu0 force-pushed the invite_link_issues branch from 7c277ad to 4e3c479 Compare April 23, 2025 07:57
@LucasXu0 LucasXu0 force-pushed the invite_link_issues branch from 6c41f9e to 5d386e7 Compare April 23, 2025 09:42
@LucasXu0 LucasXu0 merged commit 6a887fd into AppFlowy-IO:main Apr 24, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant