Skip to content

chore: disable migrate anon user #7816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

chore: disable migrate anon user #7816

merged 2 commits into from
Apr 24, 2025

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented Apr 23, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Disable anonymous user migration functionality in the AppFlowy application

Tests:

  • Remove anonymous user migration test module

Chores:

  • Remove code related to migrating anonymous user data when signing up to AppFlowy Cloud

Copy link
Contributor

sourcery-ai bot commented Apr 23, 2025

Reviewer's Guide by Sourcery

This pull request disables the automatic migration of anonymous user data to the cloud when a user signs up. The related integration test, functions, and enum variants have been removed, and the continue_sign_up function has been modified to reflect this change.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Removed the functionality to migrate anonymous user data to the cloud upon signing up.
  • Removed the af_cloud_sync_anon_user_document_test integration test.
  • Removed the migrate_anon_user_data_to_cloud function from UserManager.
  • Removed the migration_anon_user_on_appflowy_cloud_sign_up function from UserManager.
  • Removed the AnonUser option from the ImportedSource enum.
  • Modified the continue_sign_up function in UserManager to no longer accept a migration_user parameter.
  • Removed logic related to anonymous user migration in the continue_sign_up function.
  • Removed logic related to anonymous user migration in the generate_import_data function.
frontend/rust-lib/event-integration-test/tests/document/af_cloud_test/edit_test.rs
frontend/rust-lib/flowy-user/src/user_manager/manager.rs
frontend/rust-lib/flowy-user/src/user_manager/manager_user_workspace.rs
frontend/rust-lib/flowy-user/src/services/data_import/appflowy_data_import.rs
frontend/rust-lib/event-integration-test/tests/user/af_cloud_test/mod.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider removing the migration_anon_user_on_appflowy_cloud_sign_up function entirely, as it is no longer used.
  • Ensure that removing the anon user migration doesn't negatively impact any existing users or data.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@appflowy appflowy merged commit 276e650 into main Apr 24, 2025
18 of 19 checks passed
@appflowy appflowy deleted the disable_migrate_anono branch April 24, 2025 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant