-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: disable migrate anon user #7816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's Guide by SourceryThis pull request disables the automatic migration of anonymous user data to the cloud when a user signs up. The related integration test, functions, and enum variants have been removed, and the No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @appflowy - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the
migration_anon_user_on_appflowy_cloud_sign_up
function entirely, as it is no longer used. - Ensure that removing the anon user migration doesn't negatively impact any existing users or data.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Disable anonymous user migration functionality in the AppFlowy application
Tests:
Chores: