-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: anon user can not locate its data #7873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis pull request fixes an issue preventing anonymous users from accessing their data by adding a fallback mechanism to identify their local workspace type during session loading. It also ensures the anonymous user session is correctly migrated to the new format and updates related functions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @appflowy - I've reviewed your changes - here's some feedback:
- Consider creating a tracking issue to ensure the temporary workaround for anonymous user workspace type lookup is removed after the relevant data migration is complete.
- The session migration logic for anonymous and regular users appears similar; consider refactoring into a shared function to reduce duplication.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Fix data retrieval and migration issues for anonymous users in AppFlowy
Bug Fixes:
Enhancements:
Tests: