Skip to content

refactor: extract event handler #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025
Merged

refactor: extract event handler #7908

merged 2 commits into from
May 11, 2025

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented May 10, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Refactor the UserWorkspaceBloc by extracting event handlers into separate methods to improve code readability and maintainability

Enhancements:

  • Extracted complex event handling logic into smaller, focused methods
  • Added helper methods to reduce code duplication
  • Improved code organization by separating concerns

Copy link
Contributor

sourcery-ai bot commented May 10, 2025

Reviewer's Guide

This pull request refactors the UserWorkspaceBloc by extracting the inline logic for each UserWorkspaceEvent into dedicated private handler methods (e.g., _initializeWorkspaces, _handleFetchWorkspaces). This improves modularity and readability, supported by new private helper methods (_sortWorkspaces, _findWorkspaceById, _updateWorkspaceInList) for workspace list manipulation and a _setupListeners method for listener initialization.

File-Level Changes

Change Details Files
Decomposed the main event handler by extracting logic for each UserWorkspaceEvent into dedicated private methods.
  • Moved event-specific processing from the main on<UserWorkspaceEvent> block to new methods such as _initializeWorkspaces, _handleFetchWorkspaces, _handleCreateWorkspace, _handleDeleteWorkspace, _handleOpenWorkspace, _handleRenameWorkspace, _handleUpdateWorkspaceIcon, _handleLeaveWorkspace, and _handleUpdateCurrentWorkspace.
  • Extracted listener setup logic (previously in the initial event handler) into a new _setupListeners method.
frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart
Introduced private helper methods to manage workspace lists and reduce code duplication.
  • Added _sortWorkspaces method to centralize and consistently apply sorting logic to workspace lists.
  • Added _findWorkspaceById method to simplify retrieving specific workspaces from lists.
  • Added _updateWorkspaceInList method to provide a standardized way to update a workspace within the existing list.
frontend/appflowy_flutter/lib/workspace/application/user/user_workspace_bloc.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes - here's some feedback:

  • The new _sortWorkspaces method is a pure function; consider making it static or moving it to a shared utility.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 merged commit 6e850ab into main May 11, 2025
20 checks passed
@LucasXu0 LucasXu0 deleted the user_workspace_bloc_refactor branch May 11, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants