Skip to content

chore: remove unused ai code #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

chore: remove unused ai code #7919

merged 1 commit into from
May 12, 2025

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented May 12, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Remove unused AI-related code and dependencies from the Rust frontend libraries

Build:

  • Remove unused dependencies (af-plugin, af-local-ai, af-mcp) from Cargo.toml across multiple crates

Chores:

  • Remove stream_util.rs, watch.rs, and its module declaration in local_ai
  • Remove From<RunningState> implementation in entities.rs

Copy link
Contributor

sourcery-ai bot commented May 12, 2025

Reviewer's Guide

This PR removes unused AI-related code, including streaming utilities, the watch module, and conversion implementations, and cleans up obsolete dependencies in various Cargo.toml files across the project.

File-Level Changes

Change Details Files
Removed local AI streaming utilities and related constants
  • Deleted QuestionStream struct and its Stream implementation
  • Removed STEAM_METADATA_KEY and STEAM_ANSWER_KEY handling
  • Dropped plugin error and JSON parsing imports
frontend/rust-lib/flowy-ai/src/local_ai/stream_util.rs
Removed RunningState to protobuf conversion
  • Deleted From for RunningStatePB implementation
frontend/rust-lib/flowy-ai/src/entities.rs
Removed unused watch module
  • Deleted watch.rs file
  • Removed pub mod watch import in local_ai mod
frontend/rust-lib/flowy-ai/src/local_ai/mod.rs
frontend/rust-lib/flowy-ai/src/local_ai/watch.rs
Cleaned up obsolete AI dependencies in Cargo manifests
  • Removed af-plugin, af-local-ai, af-mcp entries
  • Dropped commented tooling instructions and workspace deps
  • Pruned lockfile references
frontend/rust-lib/Cargo.toml
frontend/rust-lib/flowy-ai/Cargo.toml
frontend/rust-lib/flowy-core/Cargo.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes - here's some feedback:

  • Since stream_util.rs only retains two constants after removal, consider deleting those constants or the entire file if they’re no longer used to avoid dead code.
  • You removed the From<RunningState> for RunningStatePB impl—make sure any code or tests relying on that conversion are updated to prevent compilation failures.
  • Verify that there are no remaining imports or references to the deleted watch module or QuestionStream type across the workspace to avoid unresolved references.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@appflowy appflowy merged commit 7e5b243 into main May 12, 2025
11 of 20 checks passed
@appflowy appflowy deleted the remove_unused_ai_code branch May 12, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant