-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: remove unused ai code #7919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR removes unused AI-related code, including streaming utilities, the watch module, and conversion implementations, and cleans up obsolete dependencies in various Cargo.toml files across the project. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @appflowy - I've reviewed your changes - here's some feedback:
- Since
stream_util.rs
only retains two constants after removal, consider deleting those constants or the entire file if they’re no longer used to avoid dead code. - You removed the
From<RunningState> for RunningStatePB
impl—make sure any code or tests relying on that conversion are updated to prevent compilation failures. - Verify that there are no remaining imports or references to the deleted
watch
module orQuestionStream
type across the workspace to avoid unresolved references.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Feature Preview
PR Checklist
Summary by Sourcery
Remove unused AI-related code and dependencies from the Rust frontend libraries
Build:
af-plugin
,af-local-ai
,af-mcp
) from Cargo.toml across multiple cratesChores:
stream_util.rs
,watch.rs
, and its module declaration inlocal_ai
From<RunningState>
implementation inentities.rs