Skip to content

fix: stream key #7952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

fix: stream key #7952

merged 1 commit into from
May 20, 2025

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented May 20, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Introduce typed stream messages for AI error conditions and update chat streaming error handling to use them instead of raw string keys.

Enhancements:

  • Add new StreamMessage variants for various AI error conditions and implement their Display formatting
  • Refactor chat.rs error handling to send StreamMessage variants instead of hardcoded error strings

Copy link
Contributor

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

Refactors streaming error handling by introducing new StreamMessage enum variants for various AI and local AI limits/statuses and updating chat streaming logic to send these variants instead of raw string literals.

File-Level Changes

Change Details Files
Replaced hardcoded error string sends with serialized StreamMessage variants in chat streaming
  • Send StreamMessage::AIResponseLimitExceeded instead of "AI_RESPONSE_LIMIT"
  • Send StreamMessage::AIImageResponseLimitExceeded instead of "AI_IMAGE_RESPONSE_LIMIT"
  • Use StreamMessage::AIMaxRequired(err.msg) instead of formatted string
  • Use StreamMessage::LocalAINotReady(err.msg) instead of formatted string
  • Use StreamMessage::LocalAIDisabled(err.msg) instead of formatted string
frontend/rust-lib/flowy-ai/src/chat.rs
Extended StreamMessage enum with new variants for AI error and local AI status conditions and implemented their Display serialization
  • Added AIResponseLimitExceeded and AIImageResponseLimitExceeded variants
  • Added AIMaxRequired, LocalAINotReady, and LocalAIDisabled variants
  • Updated Display impl to format new variants
frontend/rust-lib/flowy-ai/src/stream_message.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Collaborator

@richardshiue richardshiue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@appflowy appflowy merged commit 49b56f0 into main May 20, 2025
20 checks passed
@appflowy appflowy deleted the fix_stream_key branch May 20, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants