Skip to content

chore: enable index on mobile #7954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: enable index on mobile #7954

wants to merge 2 commits into from

Conversation

appflowy
Copy link
Contributor

@appflowy appflowy commented May 20, 2025

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Enable collab embedding and instant indexing on mobile by removing desktop-only operating system checks

Enhancements:

  • Remove desktop OS guard in AppFlowyCollabBuilder to allow embedding writer tasks on mobile
  • Remove desktop-only checks in InstantIndexedDataWriter to enable instant index provider and writer on mobile

Copy link
Contributor

sourcery-ai bot commented May 20, 2025

Reviewer's Guide

This PR removes desktop-only guards in the collab-integrate module, activating embedding and instant indexing routines on all platforms (including mobile) by eliminating early returns based on is_desktop checks.

File-Level Changes

Change Details Files
Remove conditional desktop-only guard around collab embedding.
  • Dropped get_operating_system().is_desktop() check before spawning the embedding task
  • Unindented and always spawn tokio task for queue_collab_embed
frontend/rust-lib/collab-integrate/src/collab_builder.rs
Enable instant indexed data provider on mobile by removing non-desktop early exits.
  • Removed early return in spawn_instant_indexed_provider based on OS
  • Removed non-desktop guard in the consumer handler method
frontend/rust-lib/collab-integrate/src/instant_indexed_data_provider.rs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @appflowy - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

let weak_collab = Arc::downgrade(&collab);
let weak_embedding_writer = self.embeddings_writer.clone();
tokio::spawn(async move {
if let Some(embedding_writer) = weak_embedding_writer.and_then(|w| w.upgrade()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (bug_risk): Consider handling the spawned task’s JoinHandle

Keep the JoinHandle or use a task manager to track errors, manage shutdown order, or cancel pending tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant