-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
chore: enable index on mobile #7954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR removes desktop-only guards in the collab-integrate module, activating embedding and instant indexing routines on all platforms (including mobile) by eliminating early returns based on is_desktop checks. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @appflowy - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
let weak_collab = Arc::downgrade(&collab); | ||
let weak_embedding_writer = self.embeddings_writer.clone(); | ||
tokio::spawn(async move { | ||
if let Some(embedding_writer) = weak_embedding_writer.and_then(|w| w.upgrade()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (bug_risk): Consider handling the spawned task’s JoinHandle
Keep the JoinHandle or use a task manager to track errors, manage shutdown order, or cancel pending tasks.
Feature Preview
PR Checklist
Summary by Sourcery
Enable collab embedding and instant indexing on mobile by removing desktop-only operating system checks
Enhancements: