-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: make the link align center while sitename is empty #7955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's GuideIntroduce a hasSiteName flag and conditionally render the site name and its spacing in the LinkEmbedBlockComponent to ensure the URL is centered when no site name is provided. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @asjqkkkk - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -188,6 +188,7 @@ class LinkEmbedBlockComponentState | |||
|
|||
Widget buildContent(BuildContext context) { | |||
final theme = AppFlowyTheme.of(context), textScheme = theme.textColorScheme; | |||
final hasSiteName = linkInfo.siteName?.isNotEmpty ?? false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider trimming siteName
when checking emptiness
Use linkInfo.siteName?.trim().isNotEmpty to avoid treating whitespace-only siteName as non-empty and rendering blank spacers or text.
final hasSiteName = linkInfo.siteName?.isNotEmpty ?? false; | |
final hasSiteName = linkInfo.siteName?.trim().isNotEmpty ?? false; |
Feature Preview
PR Checklist
Summary by Sourcery
Bug Fixes: