Skip to content

fix: prevent location from being accessed continuously on Windows #8110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Jul 8, 2025

Feature Preview

LucasXu0/flutter-permission-handler@faef1c9


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Summary by Sourcery

Update dependency overrides to apply a patched flutter_permission_handler commit that prevents continuous location access on Windows and clean up unused auto_updater overrides

Bug Fixes:

  • Override the permission_handler plugin to a custom commit that stops continuous Windows location access

Chores:

  • Remove commented-out local auto_updater package overrides from pubspec.yaml

Copy link
Contributor

sourcery-ai bot commented Jul 8, 2025

Reviewer's Guide

This PR configures the Flutter project to use a specific forked version of the permission_handler plugin (locked to a commit) to stop continuous Windows location polling and removes obsolete local package overrides for a cleaner dependency setup.

File-Level Changes

Change Details Files
Replaced permission_handler dependency to address continuous location access on Windows
  • Added a git-based override for permission_handler pointing to LucasXu0/flutter-permission-handler at commit faef1c9
  • Specified url, path, and ref under dependency_overrides
frontend/appflowy_flutter/pubspec.yaml
Removed unused local dependency overrides and cleaned up pubspec
  • Deleted commented-out auto_updater local package overrides
  • Removed an extraneous blank line in the dependencies section
frontend/appflowy_flutter/pubspec.yaml
frontend/appflowy_flutter/pubspec.lock

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @LucasXu0 - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@LucasXu0 LucasXu0 merged commit 7599c19 into AppFlowy-IO:main Jul 8, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant