Skip to content

Bump minimum CMake version to 3.6 #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trinitronx
Copy link
Contributor

Fixes build with CMake 4.0.2 which shows error:

CMake Error at PKGBUILD-AUR_fix/a/appimagelauncher-git/src/build/_deps/libappimage-src/src/libappimage/CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

Related to:

@TheAssassin
Copy link
Member

For the record, I don't mind the change to 3.6, but 3.5 would be the actual minimum target.

@TheAssassin
Copy link
Member

Reminds me that we need to use the ARM runners here, too.

@TheAssassin TheAssassin merged commit e5f6ea5 into AppImageCommunity:master May 24, 2025
6 checks passed
@TheAssassin
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants