-
Notifications
You must be signed in to change notification settings - Fork 49
Algo 1/fix vulnerabilities #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ms-identity-docs-code-javascript into algo-1/fix-vulnerabilities
iambmelt
approved these changes
Aug 14, 2024
iambmelt
approved these changes
Aug 15, 2024
OwenRichards1
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for the help with this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix vulnerabilities in dependencies
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Other Information
The code changes in protect-api/app.js and protected-api-access-protected-api/app.js are due to upgrading the express-jwt library to a major version that had breaking changes. This upgrade is necessary for fixing security vulnerabilities. The official description of the changes can be found in the link -> https://www.npmjs.com/package/express-jwt#migration-from-v6
Regarding the angular-SPA, it had errors on running
npm install
the resolution was to upgrade angular to 17 and some other package upgrades. This required some minor changes to polyfill.ts & the anguar.json