Skip to content

Algo 1/fix vulnerabilities #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 16, 2024
Merged

Algo 1/fix vulnerabilities #136

merged 12 commits into from
Aug 16, 2024

Conversation

algo-1
Copy link
Collaborator

@algo-1 algo-1 commented Aug 13, 2024

Purpose

Fix vulnerabilities in dependencies

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: Update dependencies to fix vulnerabilities, modify code to account for breaking changes in updated versions. See Other Information for details.

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code
For each sample, 
cd into the sample directory and follow the Readme instructions

Other Information

The code changes in protect-api/app.js and protected-api-access-protected-api/app.js are due to upgrading the express-jwt library to a major version that had breaking changes. This upgrade is necessary for fixing security vulnerabilities. The official description of the changes can be found in the link -> https://www.npmjs.com/package/express-jwt#migration-from-v6

Regarding the angular-SPA, it had errors on running npm install the resolution was to upgrade angular to 17 and some other package upgrades. This required some minor changes to polyfill.ts & the anguar.json

@algo-1 algo-1 marked this pull request as ready for review August 13, 2024 15:36
@algo-1 algo-1 requested a review from OwenRichards1 August 13, 2024 15:36
@algo-1 algo-1 requested a review from iambmelt August 15, 2024 19:10
@algo-1 algo-1 requested review from OwenRichards1 and removed request for OwenRichards1 August 16, 2024 07:23
Copy link
Collaborator

@OwenRichards1 OwenRichards1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for the help with this!

@algo-1 algo-1 merged commit ad3b6ca into main Aug 16, 2024
1 check passed
@algo-1 algo-1 deleted the algo-1/fix-vulnerabilities branch August 16, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants