Skip to content

JavaScript sample update #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Mar 3, 2025
Merged

JavaScript sample update #155

merged 18 commits into from
Mar 3, 2025

Conversation

OwenRichards1
Copy link
Collaborator

Purpose

Sample was not working in msal-browser v2 - have upgrade to msal browser v4 and updated dependencies.

Sample now working with both popup & redirect URI in workforce + external tenants.

Does this introduce a breaking change?

[X] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:


## What to Check
Verify that the following are valid
* ...

## Other Information
<!-- Add any other helpful information that may be needed here. -->

dependabot bot and others added 18 commits September 6, 2023 13:21
@dependabot @OwenRichards1
[GTD][Code Sample] React SPA Code Sample Update (ADO-54223) (Azure-Sa…
d87c00f 
…mples#50)

* react-spa-code-update

* remove-files
@OwenRichards1
Merge branch 'main' of https://github.com/OwenRichards1/ms-identity-d…
ddafbea 
…ocs-code-javascript
@OwenRichards1
Merge branch 'main' of https://github.com/Azure-Samples/ms-identity-d…
16035ed 
…ocs-code-javascript
@OwenRichards1
Merge branch 'main' of https://github.com/Azure-Samples/ms-identity-d…
cb0c15b 
…ocs-code-javascript
@OwenRichards1
Merge branch 'main' of https://github.com/Azure-Samples/ms-identity-d…
d8a727e 
…ocs-code-javascript
@OwenRichards1
Merge branch 'main' of https://github.com/Azure-Samples/ms-identity-d…
38abfb9 
…ocs-code-javascript
@OwenRichards1
update-vanillajs-app
b90a93c
@OwenRichards1
update-changes
9e389f4
@OwenRichards1
update-README
3918670
@OwenRichards1
update-README
6580905
@OwenRichards1
Merge branch 'main' into vanillajs-update
de376c2
@OwenRichards1
update-README
d85efa1
@OwenRichards1
Merge branch 'vanillajs-update' of https://github.com/OwenRichards1/m…
9a75194 
…s-identity-docs-code-javascript into vanillajs-update
@OwenRichards1
update-config
de20aaa
@OwenRichards1
update-auth-config
9bef76c
@OwenRichards1
vanilla-js-updates
7ee4cfe
@OwenRichards1
Merge branch 'main' of https://github.com/Azure-Samples/ms-identity-d…
205812a 
…ocs-code-javascript into vanillajs-update
@OwenRichards1
udate-sample-to-fix-plus-upgrade
bdfb396
cilwerner
cilwerner approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@cilwerner cilwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OwenRichards1 OwenRichards1 merged commit 0550b1f into Azure-Samples:main Mar 3, 2025
1 check passed
@OwenRichards1 OwenRichards1 deleted the vanillajs-update branch March 10, 2025 17:08
@bartduisters
Copy link

The double module.exports introduced in this PR feels like a mistake: vanillajs-spa/App/public/authConfig.js

@OwenRichards1 OwenRichards1 mentioned this pull request Mar 19, 2025
Merged
@OwenRichards1
Copy link
Collaborator Author

Thanks for spotting this @bartduisters - I've raised the above PR to fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cilwerner cilwerner cilwerner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OwenRichards1 @bartduisters @cilwerner