test(client): cleaning up imds tests #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeji3
force-pushed
the
rafael/imds_test-to-vanilla
branch
from
b9b96c2 to
3b7c1bc
Compare
rmeji3
force-pushed
the
rafael/imds_test-to-vanilla
branch
from
309bd8c to
d5071c6
Compare
…e/aks-secure-tls-bootstrap into rafael/imds_test-to-vanilla
…e/aks-secure-tls-bootstrap into rafael/imds_test-to-vanilla
client/internal/imds/imds_test.go
Outdated
| tests := []struct { | ||
| name string | ||
| json string | ||
| expectedErrSubStr string // Empty string indicates no error expected |
There was a problem hiding this comment.
nit: expecterErrSubStr -> 'expectedErr`
There was a problem hiding this comment.
this is still expectedErrSubStr
There was a problem hiding this comment.
this is still
expectedErrSubStr
did u want me to also change it to error type or leave it as a string?
|
@rmeji3 lgtm other than the 2 nits I just left |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.