-
Notifications
You must be signed in to change notification settings - Fork 4k
Az.Migrate - New-AzMigrateServerReplication - Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc #28019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
fixed dupe line
Fixed per PR request
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Need to test whether the lines of code after the new cmdlet will work as is. Working with migrate team on testing these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with Yan, parameter output looks compatible.
PS C:\Users\yanxu1> $allAvailableSkus = Get-AzComputeResourceSKU -Location eastus | Where-Object { $_.ResourceType.Contains("virtualMachines") }
PS C:\Users\yanxu1> $null -ne $allAvailableSkus
True
PS C:\Users\yanxu1> $matchingComputeSku = $allAvailableSkus | Where-Object { $_.Name -eq 'Standard_M176ds_4_v3' }
PS C:\Users\yanxu1> $null -ne $matchingComputeSku
True
PS C:\Users\yanxu1> $TargetVMSize = $matchingComputeSku.Name
PS C:\Users\yanxu1> $TargetVMSize
Standard_M176ds_4_v3
Minor change in
New-AzMigrateServerReplication
to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -locDescription
Minor change in
New-AzMigrateServerReplication
to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -locMandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
[ X] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.Done - not sure of the version for the release