Skip to content

Az.Migrate - New-AzMigrateServerReplication - Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc #28019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

ChristopherGLewis
Copy link
Contributor

Minor change in New-AzMigrateServerReplication to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc

Description

Minor change in New-AzMigrateServerReplication to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      Done - not sure of the version for the release

Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@YanaXu
Copy link
Contributor

YanaXu commented Jun 25, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@YanaXu
Copy link
Contributor

YanaXu commented Jun 30, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@prsadhu-ms-idc
Copy link

prsadhu-ms-idc commented Jun 30, 2025

Need to test whether the lines of code after the new cmdlet will work as is. Working with migrate team on testing these changes.

@prsadhu-ms-idc prsadhu-ms-idc self-requested a review June 30, 2025 11:10
Copy link

@prsadhu-ms-idc prsadhu-ms-idc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with Yan, parameter output looks compatible.

PS C:\Users\yanxu1> $allAvailableSkus = Get-AzComputeResourceSKU -Location eastus | Where-Object { $_.ResourceType.Contains("virtualMachines") }
PS C:\Users\yanxu1> $null -ne $allAvailableSkus
True
PS C:\Users\yanxu1> $matchingComputeSku = $allAvailableSkus | Where-Object { $_.Name -eq 'Standard_M176ds_4_v3' }
PS C:\Users\yanxu1> $null -ne $matchingComputeSku
True
PS C:\Users\yanxu1> $TargetVMSize = $matchingComputeSku.Name
PS C:\Users\yanxu1> $TargetVMSize
Standard_M176ds_4_v3

@YanaXu YanaXu merged commit 4637215 into Azure:main Jul 1, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants