Az.Migrate - New-AzMigrateServerReplication - Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc #28019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
Minor change to switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -loc
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
YanaXu
reviewed
Jun 25, 2025
src/Migrate/Migrate.Autorest/custom/New-AzMigrateServerReplication.ps1
Outdated
Show resolved
Hide resolved
YanaXu
reviewed
Jun 25, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
fixed dupe line
Fixed per PR request
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
prsadhu-ms-idc
approved these changes
Jun 30, 2025
|
Need to test whether the lines of code after the new cmdlet will work as is. Working with migrate team on testing these changes. |
prsadhu-ms-idc
approved these changes
Jul 1, 2025
There was a problem hiding this comment.
As discussed with Yan, parameter output looks compatible.
PS C:\Users\yanxu1> $allAvailableSkus = Get-AzComputeResourceSKU -Location eastus | Where-Object { $_.ResourceType.Contains("virtualMachines") }
PS C:\Users\yanxu1> $null -ne $allAvailableSkus
True
PS C:\Users\yanxu1> $matchingComputeSku = $allAvailableSkus | Where-Object { $_.Name -eq 'Standard_M176ds_4_v3' }
PS C:\Users\yanxu1> $null -ne $matchingComputeSku
True
PS C:\Users\yanxu1> $TargetVMSize = $matchingComputeSku.Name
PS C:\Users\yanxu1> $TargetVMSize
Standard_M176ds_4_v3
YanaXu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change in
New-AzMigrateServerReplicationto switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -locDescription
Minor change in
New-AzMigrateServerReplicationto switch deprecated Get-AzVMSize -loc to Get-AzComputeResourceSKU -locMandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
[ X] Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.Done - not sure of the version for the release