Updated New-AzFirewallPolicyApplicationRule to only use HTTPS as the default Protocol for FqdnTag rules #28027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tp,mssql) for new application rules. Added a test scenario and record to confirm new default protocol and confirm that manually setting the protocol for FqdnTag application rules is not allowed.
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the default protocol for FQDN Tag application rules in Azure Firewall Policy to use only HTTPS. The changes remove the previously allowed protocols ("http" and "mssql") and include new tests to validate the default behavior and disallow manual protocol overrides.
- Updated the default protocol in the application rule command.
- Added and updated tests (both PowerShell and C#) for FQDN Tag rules.
- Updated the changelog accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/Network/ChangeLog.md | Updated changelog entry for the new default protocol. |
| src/Network/Network/AzureFirewallPolicy/ApplicationRuleCondition/NewAzureFirewallPolicyApplicationRuleCommand.cs | Modified protocol array to include only "https" for FQDN Tag rules. |
| src/Network/Network.Test/SessionRecords/Commands.Network.Test.ScenarioTests.AzureFirewallPolicyTests/TestAzureFirewallPolicyApplicationRuleFqdnTagDefaultProtocol.json | Added test record for verifying default protocol. |
| src/Network/Network.Test/ScenarioTests/AzureFirewallPolicyTests.ps1 | Added a new test function to check protocol behavior. |
| src/Network/Network.Test/ScenarioTests/AzureFirewallPolicyTests.cs | Added a test method for FQDN Tag default protocol verification. |
Comments suppressed due to low confidence (1)
src/Network/Network/AzureFirewallPolicy/ApplicationRuleCondition/NewAzureFirewallPolicyApplicationRuleCommand.cs:164
- Ensure that the protocol string 'https' is normalized to 'Https' as expected by the tests to maintain consistency with documented behavior.
this.Protocol = new string[] {"https"}; // "http" and "mssql" are not allowed for FqdnTags
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
…proxy CRUD test. Includes replacing the secrets in the session records.
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28027 in repo Azure/azure-powershell |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Overview
Changed the default protocol to be https (instead of https, http, mssql) for new FQDN tag application rules. Added a test scenario and record to confirm new default protocol and confirm that manually setting the protocol for FQDN tag application rules is not allowed.
Additional changes
Replaced a packet capture URL secret with a fake URL and updated the accompanying test records with the same fake URL.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.