Skip to content

DesktopVirtualization for 2025-03-01-preview #28060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Zoe1808
Copy link
Member

@Zoe1808 Zoe1808 commented Jun 30, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings June 30, 2025 06:58
Copilot

This comment was marked as outdated.

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Zoe1808 Zoe1808 changed the base branch from main to Az.DesktopVirtualization-preview June 30, 2025 07:00
@YanaXu YanaXu self-assigned this Jun 30, 2025
@YanaXu
Copy link
Contributor

YanaXu commented Jun 30, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@vidai-msft vidai-msft requested a review from Copilot July 1, 2025 03:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the API version references from 2024-11-01-preview to 2025-03-01-preview across multiple recording files and test scripts, while also renaming parameters to reflect the new API contract and updating response payload structures.

  • Updated API endpoints and response headers in recording JSON files.
  • Renamed parameters in test scripts (e.g. from –DiskInfoType to –ManagedDiskType) to align with updated API design.

Reviewed Changes

Copilot reviewed 61 out of 174 changed files in this pull request and generated no comments.

File Description
New-AzWvdSessionHostManagement.Recording.json Adjusted API version and updated request/response payloads for session host management.
New-AzWvdSessionHostConfiguration.Tests.ps1 Updated parameter name from -DiskInfoType to -ManagedDiskType in test invocation.
New-AzWvdSessionHostConfiguration.Recording.json Revised API version and enriched response content with additional properties (e.g. provisioning details).
New-AzWvdScalingPlanPooledSchedule.Recording.json Updated API version and adjusted payload structure for scaling plan pooled schedules.
Comments suppressed due to low confidence (4)

src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdSessionHostManagement.Recording.json:2

  • The API version update to 2025-03-01-preview has been applied here. Please verify that the updated request and response payloads—such as the additional provisioning properties—fully conform to the new API contract.
  "New-AzWvdSessionHostManagement+[NoContext]+CreateExpanded+$PUT+https://management.azure.com/subscriptions/dbedef25-184c-430f-b383-0eeb87c3205d/resourceGroups/alecbUserSessionTests/providers/Microsoft.DesktopVirtualization/hostPools/alecbhpuHP/sessionHostManagements/default?api-version=2025-03-01-preview+1": {

src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdSessionHostConfiguration.Tests.ps1:42

  • The parameter has been updated from '-DiskInfoType' to '-ManagedDiskType' for improved clarity and consistency with the API update. Ensure that any related documentation or command help details are also updated accordingly.
                -HostPoolName $env.HostPool -ManagedDiskType "Standard_LRS" `

src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdSessionHostConfiguration.Recording.json:2

  • The API version change is reflected in this recording, and new properties (such as provisioning details) are included in the response. Please double-check that these structural changes match the latest API specification.
  "New-AzWvdSessionHostConfiguration+[NoContext]+CreateExpanded+$PUT+https://management.azure.com/subscriptions/dbedef25-184c-430f-b383-0eeb87c3205d/resourceGroups/alecbUserSessionTests/providers/Microsoft.DesktopVirtualization/hostPools/HostPoolPowershellContained1?api-version=2025-03-01-preview+1": {

src/DesktopVirtualization/DesktopVirtualization.Autorest/test/New-AzWvdScalingPlanPooledSchedule.Recording.json:2

  • The API version has been updated to 2025-03-01-preview in this scaling plan recording. Confirm that the new schema and any payload changes (if applicable) are thoroughly validated in integration tests.
  "New-AzWvdScalingPlanPooledSchedule+[NoContext]+New+$PUT+https://management.azure.com/subscriptions/dbedef25-184c-430f-b383-0eeb87c3205d/resourceGroups/alecbUserSessionTests/providers/Microsoft.DesktopVirtualization/scalingPlans/ScalingPlanPowershellContained1?api-version=2025-03-01-preview+1": {

@Zoe1808
Copy link
Member Author

Zoe1808 commented Jul 1, 2025

/azp run

1 similar comment
@YanaXu
Copy link
Contributor

YanaXu commented Jul 1, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 28060 in repo Azure/azure-powershell

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jul 1, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jul 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jul 2, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu YanaXu merged commit c3d5b81 into Azure:Az.DesktopVirtualization-preview Jul 2, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants