-
Notifications
You must be signed in to change notification settings - Fork 4k
Add batch generation parameter #28064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
9648a7d
to
e7b8f31
Compare
2bbef27
to
0b86213
Compare
61ff970
to
b8be3f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new parameters to the batch generation pipeline for finer control over which modules are processed, how branches are handled, and who receives failure notifications.
- Added five parameters (
TestChangedModulesOnly
,SelectedTargetModules
,NotificationReceiversOverride
,GenerationBaseBranch
,PrepareModulesOnGenerationBranch
) to the pipeline YAML. - Updated pipeline steps to display and wire those parameters into scripts and tasks.
- Enhanced PowerShell helper scripts (
util.psm1
,notify-failed-job.ps1
,filter.ps1
) to respect the new parameters.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
.azure-pipelines/batch-generation.yml | Added parameters, showVariables task, and wired them into tasks |
.azure-pipelines/PipelineSteps/BatchGeneration/util.psm1 | Filter modules by SELECTED_TARGET_MODULES |
.azure-pipelines/PipelineSteps/BatchGeneration/notify-failed-job.ps1 | Allow override of notification receivers via env var |
.azure-pipelines/PipelineSteps/BatchGeneration/filter.ps1 | Use TEST_CHANGED_MODULES_ONLY env var to conditionally run tests |
Comments suppressed due to low confidence (1)
.azure-pipelines/batch-generation.yml:2
- The
displayName
line is prefixed with a hyphen, which will be parsed as a new parameter rather than an attribute ofTestChangedModulesOnly
. Remove the extra-
so it readsdisplayName: ...
under the same parameter block.
- name: TestChangedModulesOnly
Add some parameters for batch generation pipeline to improve dynamically control for certain test senarios.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.