Skip to content

Add batch generation parameter #28064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 7, 2025
Merged

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Jun 30, 2025

Add some parameters for batch generation pipeline to improve dynamically control for certain test senarios.

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi force-pushed the bernard-add-batch-generation-parameter branch from 9648a7d to e7b8f31 Compare June 30, 2025 15:00
@Pan-Qi Pan-Qi force-pushed the bernard-add-batch-generation-parameter branch from 2bbef27 to 0b86213 Compare July 1, 2025 06:42
@Pan-Qi Pan-Qi force-pushed the bernard-add-batch-generation-parameter branch from 61ff970 to b8be3f7 Compare July 3, 2025 14:29
@Pan-Qi Pan-Qi marked this pull request as ready for review July 7, 2025 01:28
@Copilot Copilot AI review requested due to automatic review settings July 7, 2025 01:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new parameters to the batch generation pipeline for finer control over which modules are processed, how branches are handled, and who receives failure notifications.

  • Added five parameters (TestChangedModulesOnly, SelectedTargetModules, NotificationReceiversOverride, GenerationBaseBranch, PrepareModulesOnGenerationBranch) to the pipeline YAML.
  • Updated pipeline steps to display and wire those parameters into scripts and tasks.
  • Enhanced PowerShell helper scripts (util.psm1, notify-failed-job.ps1, filter.ps1) to respect the new parameters.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.azure-pipelines/batch-generation.yml Added parameters, showVariables task, and wired them into tasks
.azure-pipelines/PipelineSteps/BatchGeneration/util.psm1 Filter modules by SELECTED_TARGET_MODULES
.azure-pipelines/PipelineSteps/BatchGeneration/notify-failed-job.ps1 Allow override of notification receivers via env var
.azure-pipelines/PipelineSteps/BatchGeneration/filter.ps1 Use TEST_CHANGED_MODULES_ONLY env var to conditionally run tests
Comments suppressed due to low confidence (1)

.azure-pipelines/batch-generation.yml:2

  • The displayName line is prefixed with a hyphen, which will be parsed as a new parameter rather than an attribute of TestChangedModulesOnly. Remove the extra - so it reads displayName: ... under the same parameter block.
- name: TestChangedModulesOnly

@YanaXu YanaXu merged commit ece7ad9 into main Jul 7, 2025
12 checks passed
@YanaXu YanaXu deleted the bernard-add-batch-generation-parameter branch July 7, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants