-
Notifications
You must be signed in to change notification settings - Fork 4k
Improving Test-AzPostgreSqlFlexibleServerConnect #28077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…o Test-AzPostgreSqlFlexibleServerConnect cmdlet
…parameter for Test-AzPostgreSqlFlexibleServerConnect
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the Test-AzPostgreSqlFlexibleServerConnect cmdlet by introducing a Timeout parameter and making associated documentation and version updates.
- Added a -Timeout parameter across help files, docs, and custom test scripts.
- Updated the ChangeLog, module manifest, and solution files to reflect new release details.
- Made minor version bumps and updated generate-info identifiers.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/PostgreSql/PostgreSql/help/Test-AzPostgreSqlFlexibleServerConnect.md | Updated usage examples and added documentation for the -Timeout parameter. |
src/PostgreSql/PostgreSql/ChangeLog.md | Changelog updated to capture the new Timeout parameter feature. |
src/PostgreSql/PostgreSql/Az.PostgreSql.psd1 | Updated generated date and required module version. |
src/PostgreSql/PostgreSql.sln | Adjusted project GUIDs to match the new build configuration. |
src/PostgreSql/PostgreSql.Autorest/generate-info.json | Updated generate_Id for the Autorest project. |
src/PostgreSql/PostgreSql.Autorest/docs/Test-AzPostgreSqlFlexibleServerConnect.md | Synchronized usage examples and documentation with the new -Timeout parameter. |
src/PostgreSql/PostgreSql.Autorest/custom/Test-AzPostgreSqlFlexibleServerConnect.ps1 | Incorporated the new Timeout parameter in the script but introduced an inconsistency in variable naming. |
src/PostgreSql/PostgreSql.Autorest/Properties/AssemblyInfo.cs | Bumped assembly version to 1.3.0. |
if ($TimeoutValue -gt 0) { | ||
$OpenConnParams['CommandTimeout'] = $TimeoutValue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parameter is defined as 'Timeout' but is referenced as '$TimeoutValue'; please update the variable name to 'Timeout' (or vice versa) to ensure consistent use and prevent runtime errors.
if ($TimeoutValue -gt 0) { | |
$OpenConnParams['CommandTimeout'] = $TimeoutValue | |
if ($Timeout -gt 0) { | |
$OpenConnParams['CommandTimeout'] = $Timeout |
Copilot uses AI. Check for mistakes.
/azp run azure-powershell - security-tools |
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Fix #26975.
Fix #25499.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.