Skip to content

Improving Test-AzPostgreSqlFlexibleServerConnect #28077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

ShawnXxy
Copy link
Contributor

@ShawnXxy ShawnXxy commented Jul 1, 2025

Description

Fix #26975.
Fix #25499.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

ShawnXxy added 2 commits July 1, 2025 13:16
…o Test-AzPostgreSqlFlexibleServerConnect cmdlet
…parameter for Test-AzPostgreSqlFlexibleServerConnect
@Copilot Copilot AI review requested due to automatic review settings July 1, 2025 05:25
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the Test-AzPostgreSqlFlexibleServerConnect cmdlet by introducing a Timeout parameter and making associated documentation and version updates.

  • Added a -Timeout parameter across help files, docs, and custom test scripts.
  • Updated the ChangeLog, module manifest, and solution files to reflect new release details.
  • Made minor version bumps and updated generate-info identifiers.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/PostgreSql/PostgreSql/help/Test-AzPostgreSqlFlexibleServerConnect.md Updated usage examples and added documentation for the -Timeout parameter.
src/PostgreSql/PostgreSql/ChangeLog.md Changelog updated to capture the new Timeout parameter feature.
src/PostgreSql/PostgreSql/Az.PostgreSql.psd1 Updated generated date and required module version.
src/PostgreSql/PostgreSql.sln Adjusted project GUIDs to match the new build configuration.
src/PostgreSql/PostgreSql.Autorest/generate-info.json Updated generate_Id for the Autorest project.
src/PostgreSql/PostgreSql.Autorest/docs/Test-AzPostgreSqlFlexibleServerConnect.md Synchronized usage examples and documentation with the new -Timeout parameter.
src/PostgreSql/PostgreSql.Autorest/custom/Test-AzPostgreSqlFlexibleServerConnect.ps1 Incorporated the new Timeout parameter in the script but introduced an inconsistency in variable naming.
src/PostgreSql/PostgreSql.Autorest/Properties/AssemblyInfo.cs Bumped assembly version to 1.3.0.

Comment on lines +166 to +167
if ($TimeoutValue -gt 0) {
$OpenConnParams['CommandTimeout'] = $TimeoutValue
Copy link
Preview

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter is defined as 'Timeout' but is referenced as '$TimeoutValue'; please update the variable name to 'Timeout' (or vice versa) to ensure consistent use and prevent runtime errors.

Suggested change
if ($TimeoutValue -gt 0) {
$OpenConnParams['CommandTimeout'] = $TimeoutValue
if ($Timeout -gt 0) {
$OpenConnParams['CommandTimeout'] = $Timeout

Copilot uses AI. Check for mistakes.

@YanaXu
Copy link
Contributor

YanaXu commented Jul 1, 2025

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@YanaXu
Copy link
Contributor

YanaXu commented Jul 1, 2025

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@YanaXu YanaXu self-assigned this Jul 1, 2025
@YanaXu YanaXu merged commit d673a3a into Azure:main Jul 1, 2025
13 checks passed
@ShawnXxy ShawnXxy deleted the xixia/dev/pgfs-testconnect branch July 2, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants